[jira] [Commented] (GROOVY-8562) Wrong Closure delegation for property access when using @CompileStatic and DELEGATE_FIRST / DELEGATE_ONLY

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (GROOVY-8562) Wrong Closure delegation for property access when using @CompileStatic and DELEGATE_FIRST / DELEGATE_ONLY

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/GROOVY-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477880#comment-16477880 ]

Michael Arndt commented on GROOVY-8562:
---------------------------------------

Looked into it. I fixed the first case, but it breaks 28 other tests. But I have gained a basic understanding of the problem:

For StaticTypeCheckingVisitor the VariableExpression is a FieldNode and the IMPLICIT_RECEIVER is never set.

https://github.com/MeneDev/groovy/commit/0a47728777a15bfa986b89da7495c858396e737f

> Wrong Closure delegation for property access when using @CompileStatic and DELEGATE_FIRST / DELEGATE_ONLY
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: GROOVY-8562
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8562
>             Project: Groovy
>          Issue Type: Bug
>          Components: Static compilation
>    Affects Versions: 2.3.11, 2.6.0-alpha-3, 3.0.0-alpha-2, 2.5.0-rc-1, 2.4.15
>            Reporter: Michael Arndt
>            Priority: Major
>
> Closures resolve to owner property although `DELEGATE_FIRST` or `DELEGATE_ONLY` are set as `resolveStrategy`.
>  This only happens when `@CompileStatic` is used.
>  This does not apply to method calls.
>  For Groovy 2.3.11 this only affects read operations.
> Only the versions 2.5.0-rc-1, 2.4.15, 2.3.11 have been tested yet.
>  I will add tests for newer versions, but this requires a different test framework than Spock.
> I have created a demo project at [https://github.com/MeneDev/groovy-bugreport-closure-strategy]
>  
> {code:java}
> class ADelegate {
>     def x = "delegate"
> }
> @CompileStatic
> class AClass {
>     public <T> T closureExecuter(
>             ADelegate d,
>             @DelegatesTo(value = ADelegate, strategy = DELEGATE_ONLY) Closure<T> c) {
>         c.resolveStrategy = DELEGATE_ONLY
>         c.delegate = d
>         return c()
>     }
>     def x = "owner"
>    
>     def test() {
>         def theDelegate = new ADelegate()
>         def res = closureExecuter(theDelegate) {
>             return x
>         }
>        
>         // is "owner" instead of "delegate"
>         return res
>     }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)