[jira] [Commented] (GROOVY-8501) Switch internal details of @ImmutableBase existing constructor validation

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (GROOVY-8501) Switch internal details of @ImmutableBase existing constructor validation

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/GROOVY-8501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391244#comment-16391244 ]

ASF GitHub Bot commented on GROOVY-8501:
----------------------------------------

GitHub user paulk-asert opened a pull request:

    https://github.com/apache/groovy/pull/673

    GROOVY-8501: Switch internal details of @ImmutableBase existing const…

    …ructor validation

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paulk-asert/groovy groovy8501

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/673.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #673
   
----
commit 5fe29c30ba2b96badcf8bfb9a6f147b2f1f5114e
Author: paulk <paulk@...>
Date:   2018-03-08T13:25:24Z

    GROOVY-8501: Switch internal details of @ImmutableBase existing constructor validation

----


> Switch internal details of @ImmutableBase existing constructor validation
> -------------------------------------------------------------------------
>
>                 Key: GROOVY-8501
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8501
>             Project: Groovy
>          Issue Type: Task
>            Reporter: Paul King
>            Priority: Major
>
> Currently @ImmutableBase validates that no existing constructors are present. It requires @ImmutableBase to appear before @TupleConstructor and @MapConstructor. It allows @Builder with the InitializerStrategy to have been processed earlier and uses some node metadata tracking to allow this to happen. If we change to instead checking for the @Generated annotation instead of node metadata, these ordering restrictions can be relaxed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)