[jira] [Commented] (GROOVY-8166) Repeated operations in AnnotationCollectorTransform and Traits

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (GROOVY-8166) Repeated operations in AnnotationCollectorTransform and Traits

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/GROOVY-8166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018461#comment-16018461 ]

ASF GitHub Bot commented on GROOVY-8166:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/groovy/pull/543


> Repeated operations in AnnotationCollectorTransform and Traits
> --------------------------------------------------------------
>
>                 Key: GROOVY-8166
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8166
>             Project: Groovy
>          Issue Type: Bug
>            Reporter: Eric Milles
>            Priority: Minor
>
> I think there are a couple bits of redundant code that I have run into looking at some stuff related to traits and type checking.
> 1) In {{org.codehaus.groovy.transform.trait.Traits.isTrait(ClassNode)}}, the check for the Trait annotation appears redundant to the call to {{isAnnotatedWithTrait}}.
> 2) In {{org.codehaus.groovy.transform.AnnotationCollectorTransform.makeListOfAnnotations(Object[][])}}, the recent addition of {{copyMembers}} appears to have missed removing the following line {{toAdd.getMembers().putAll(generated);}}.  Thus I think the map {{generated}} is being asked to put the same entries twice.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Loading...