[jira] [Commented] (GROOVY-7422) @AnnotationCollector should provide more control over where collected annotations are placed

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (GROOVY-7422) @AnnotationCollector should provide more control over where collected annotations are placed

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/GROOVY-7422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539761#comment-14539761 ]

ASF GitHub Bot commented on GROOVY-7422:
----------------------------------------

GitHub user paulk-asert opened a pull request:

    https://github.com/apache/incubator-groovy/pull/14

    GROOVY-7422: @AnnotationCollector should provide more control over wh…

    …ere collected annotations are placed

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paulk-asert/incubator-groovy groovy7422

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-groovy/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14
   
----
commit cd1c452f71ff816da0b88dbad410160ed5e059cc
Author: Paul King <[hidden email]>
Date:   2015-05-12T12:26:44Z

    GROOVY-7422: @AnnotationCollector should provide more control over where collected annotations are placed

----


> @AnnotationCollector should provide more control over where collected annotations are placed
> --------------------------------------------------------------------------------------------
>
>                 Key: GROOVY-7422
>                 URL: https://issues.apache.org/jira/browse/GROOVY-7422
>             Project: Groovy
>          Issue Type: Improvement
>          Components: xforms
>    Affects Versions: 2.4.3
>            Reporter: Paul King
>            Assignee: Paul King
>             Fix For: 2.5.0-beta-1
>
>
> When expanding a meta annotation alias into its annotation collection, it is sometimes useful to be able to ensure the newly added annotations have a specific ordering with respect to the other annotations that might be on an annotated node. Currently there is a one size fits all approach. This issue proposes adding an annotation parameter to {{@AnnotationCollection}} which lets the collected annotations be placed at the front, end and inplace.
> Assuming {{@A}} and {{@C}} are annotations and {{@B}} an annotation collector aliasing two annotations {{@B1}} and {{@B2}}, then if we have the following annotation list: {{@A @B @C}} it will be replaced by the following lists of annotations:
> {code}
> FIRST: @B1 @B2 @A @C
> INPLACE: @A @B1 @B2 @C
> LAST: @A @C @B1 @B2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)