[groovy-dev] Web page on GJDK

classic Classic list List threaded Threaded
16 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[groovy-dev] Web page on GJDK

Russel Winder
Is the page http://groovy.codehaus.org/groovy-jdk.html automatically
generated so that it reflects reality or is it manually created and so
may diverge from reality?

Thanks.

--
Russel.
====================================================
Dr Russel Winder                +44 20 7585 2200
41 Buckmaster Road              +44 7770 465 077
London SW11 1EN, UK             [hidden email]

signature.asc (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [groovy-dev] Web page on GJDK

Russel Winder
I had thought that GJDK was about all the useful methods Groovy added to
standard JDK classes.  I see though that groovy.lang.GString gets a
mention.  Seems sort of out of place.
--
Russel.
====================================================
Dr Russel Winder                +44 20 7585 2200
41 Buckmaster Road              +44 7770 465 077
London SW11 1EN, UK             [hidden email]

signature.asc (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [groovy-dev] Web page on GJDK

tugwilson
In reply to this post by Russel Winder

On 3 Nov 2005, at 09:50, Russel Winder wrote:

> Is the page http://groovy.codehaus.org/groovy-jdk.html automatically
> generated so that it reflects reality or is it manually created and so
> may diverge from reality?

It's generated by the Groovy script  
our.codehaus.groovy.tools.DocGenerator.groovy

So it reflects reality (for small values of reality!)

John Wilson
The Wilson Partnership
http://www.wilson.co.uk


Reply | Threaded
Open this post in threaded view
|

Re: [groovy-dev] Web page on GJDK

tugwilson
In reply to this post by Russel Winder

On 3 Nov 2005, at 09:54, Russel Winder wrote:

> I had thought that GJDK was about all the useful methods Groovy  
> added to
> standard JDK classes.  I see though that groovy.lang.GString gets a
> mention.  Seems sort of out of place.


The page describes the methods in DefaultGroovyMethods and  
DefaultGroovyStaticMethods. It tells you want methods are available  
from Groovy which are not available from Java.

For some reason there is a negate method defined on GString so it's  
included in that page. I have absolutely no idea why it was put in  
DefaultGroovyMethods rather than added to GString.


John Wilson
The Wilson Partnership
http://www.wilson.co.uk


Reply | Threaded
Open this post in threaded view
|

Re: [groovy-dev] Web page on GJDK

Russel Winder
On Thu, 2005-11-03 at 10:00 +0000, John Wilson wrote:

> The page describes the methods in DefaultGroovyMethods and  
> DefaultGroovyStaticMethods. It tells you want methods are available  
> from Groovy which are not available from Java.

Indeed.  Exactly my point.

> For some reason there is a negate method defined on GString so it's  
> included in that page. I have absolutely no idea why it was put in  
> DefaultGroovyMethods rather than added to GString.

Exactly.  I guess this means I should try moving it and see if anything
breaks.  Does this need a JIRA issue?

--
Russel.
====================================================
Dr Russel Winder                +44 20 7585 2200
41 Buckmaster Road              +44 7770 465 077
London SW11 1EN, UK             [hidden email]

signature.asc (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [groovy-dev] Web page on GJDK

tugwilson

On 3 Nov 2005, at 10:40, Russel Winder wrote:

>
> Exactly.  I guess this means I should try moving it and see if  
> anything
> breaks.  Does this need a JIRA issue?


Try and find out who put it in and ask them if they had any special  
reason for doing so first.


John Wilson
The Wilson Partnership
http://www.wilson.co.uk


Reply | Threaded
Open this post in threaded view
|

[groovy-dev] GString.negate / negate ( GString) [ was Re: [groovy-dev] Web page on GJDK ]

Russel Winder
On Thu, 2005-11-03 at 10:44 +0000, John Wilson wrote:

> Try and find out who put it in and ask them if they had any special  
> reason for doing so first.

I think it was put in there because there was a method "public static
Pattern negate ( String )" and it was a cut-and-paste-then-edit type
activity.

There are no attributions in the code so it could be anybody.

I tried the experiment of removing "public static Pattern negate
( GString )" from DefaultGroovyMethods.java and adding "public Pattern
negate ( )" in GString.java and all the tests seem to run fine.  So on
the grounds that the tests run fine I could commit the change.  However
I am hesitant to make the commit since it may be that there are no tests
for GString.negate!

Does anyone admit to knowing anything about the negate ( GString )
method in DefaultGroovyMethods.java?

--
Russel.
====================================================
Dr Russel Winder                +44 20 7585 2200
41 Buckmaster Road              +44 7770 465 077
London SW11 1EN, UK             [hidden email]

signature.asc (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [groovy-dev] GString.negate / negate ( GString) [ was Re: [groovy-dev] Web page on GJDK ]

tugwilson

On 3 Nov 2005, at 12:49, Russel Winder wrote:

>
> There are no attributions in the code so it could be anybody.


CVS resource history is your friend here.

version 1.137: 22/02/05 jsratchan seems to be the commit that added  
these.



John Wilson
The Wilson Partnership
http://www.wilson.co.uk


Reply | Threaded
Open this post in threaded view
|

Re: [groovy-dev] Web page on GJDK

Jochen Theodorou
In reply to this post by Russel Winder
Russel Winder schrieb:
> Is the page http://groovy.codehaus.org/groovy-jdk.html automatically
> generated so that it reflects reality or is it manually created and so
> may diverge from reality?

the DocsGenerator.groovy script is producing it. There was a problem
with the script till jsr-03, but we fixed it and so the page was updated
during the last release.

bye blackdrag
Reply | Threaded
Open this post in threaded view
|

Re: [groovy-dev] GString.negate / negate ( GString) [ was Re: [groovy-dev] Web page on GJDK ]

Russel Winder
In reply to this post by tugwilson
On Thu, 2005-11-03 at 13:00 +0000, John Wilson wrote:

> version 1.137: 22/02/05 jsratchan seems to be the commit that added  
> these.

James hasn't been around for a while so I guess I'll just have to hunt
around and see if there are unit tests.
--
Russel.
====================================================
Dr Russel Winder                +44 20 7585 2200
41 Buckmaster Road              +44 7770 465 077
London SW11 1EN, UK             [hidden email]

signature.asc (196 bytes) Download Attachment
12