Hi,
I'd like to place for discussion whether
'equals' should work on arrays like on Lists.
see also
http://jira.codehaus.org/browse/GROOVY-1130Currently we have this:
- java.util.List#equals has a special impl. in the DGM:
----
public static boolean equals(List left, List right) {
if (left == null && right == null)
return true;
else if (left == null && right != null)
return false;
else if (left != null && right == null)
return false;
else if (left.size() != right.size())
return false;
NumberComparator numberComparator = new NumberComparator();
Iterator it1 = left.iterator(), it2 = right.iterator();
for (; it1.hasNext() && it2.hasNext(); ) {
Object o1 = it1.next();
Object o2 = it2.next();
if (Number.class.isInstance(o1) && Number.class.isInstance(o2))
{
if (numberComparator.compare(o1, o2) != 0)
return false;
}
else {
if (o1 == null) {
if (o1 != null)
return false;
}
else if (!o1.equals(o2))
return false;
}
}
if (it1.hasNext() || it2.hasNext())
return false;
return true;
}
----
- arrays of java primitives used with equals fall through to
identity check (like in Java)
- arrays of objects are also compared by indentity
Since arrays and Lists are often used in a Groovy codebase
interchangeably, the following is surprising:
String[] a = new String[1]
String[] b = new String[1]
a[0] = 'x'
b[0] = 'x'
assert a != b
assert a.toList() == b.toList()
suggestions?
cheers
Mittie
Locked
