[VOTE] Release Apache Groovy 2.6.0-alpha-2

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
19 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Groovy 2.6.0-alpha-2

Daniel.Sun
Dear community,

I am happy to start the VOTE thread for a Groovy 2.6.0-alpha-2 release!

This release includes 10 bug fixes/improvements as outlined in the
changelog:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12341386

Tag:
https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_6_0_ALPHA_2
Tag commit id: 3c37e8ce66613901f1b523b0519fb6ba51676270

The artifacts to be voted on are located as follows (r23058).
Source release:
https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/sources
Convenience binaries:
https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/distribution

Release artifacts are signed with a key from the following file:
https://dist.apache.org/repos/dist/dev/groovy/KEYS

Please vote on releasing this package as Apache Groovy 2.6.0-alpha-2.

The vote is open for the next 72 hours and passes if a majority of at least
three +1 PMC votes are cast.

[ ] +1 Release Apache Groovy 2.6.0-alpha-2
[ ]  0 I don't have a strong opinion about this, but I assume it's ok
[ ] -1 Do not release Apache Groovy 2.6.0-alpha-2 because...

Here is my vote:

+1 (binding)




--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2

Graeme Rocher-2
+1

On Sat, Nov 11, 2017 at 4:24 PM, Daniel.Sun <[hidden email]> wrote:

> Dear community,
>
> I am happy to start the VOTE thread for a Groovy 2.6.0-alpha-2 release!
>
> This release includes 10 bug fixes/improvements as outlined in the
> changelog:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12341386
>
> Tag:
> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_6_0_ALPHA_2
> Tag commit id: 3c37e8ce66613901f1b523b0519fb6ba51676270
>
> The artifacts to be voted on are located as follows (r23058).
> Source release:
> https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/sources
> Convenience binaries:
> https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/distribution
>
> Release artifacts are signed with a key from the following file:
> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>
> Please vote on releasing this package as Apache Groovy 2.6.0-alpha-2.
>
> The vote is open for the next 72 hours and passes if a majority of at least
> three +1 PMC votes are cast.
>
> [ ] +1 Release Apache Groovy 2.6.0-alpha-2
> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
> [ ] -1 Do not release Apache Groovy 2.6.0-alpha-2 because...
>
> Here is my vote:
>
> +1 (binding)
>
>
>
>
> --
> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html



--
Graeme Rocher
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2

Guillaume Laforge
Administrator
Hi,

I was trying to build from source with the source bundle, but it seems you can't generate the wrapper from a recent version of Gradle.
I have version 4.3.1, and when I try to launch gradle wrapper, to first create the appropriate wrapper, I get the following errors:

$ gradle wrapper


FAILURE: Build failed with an exception.


* Where:

Build file '/Users/glaforge/Downloads/groovy-2.6.0-alpha-2/build.gradle' line: 53


* What went wrong:

An exception occurred applying plugin request [id: 'com.gradle.build-scan', version: '1.6']

> Failed to apply plugin [id 'com.gradle.build-scan']

   > This version of Gradle requires version 1.8.0 of the build scan plugin or later.

     Please see https://gradle.com/scans/help/gradle-incompatible-plugin-version for more information.


* Try:

Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.


* Get more help at https://help.gradle.org


Which might also be why Cédric committed a change related to the build scan plugin?

Guillaume


On Sun, Nov 12, 2017 at 5:04 PM, Graeme Rocher <[hidden email]> wrote:
+1

On Sat, Nov 11, 2017 at 4:24 PM, Daniel.Sun <[hidden email]> wrote:
> Dear community,
>
> I am happy to start the VOTE thread for a Groovy 2.6.0-alpha-2 release!
>
> This release includes 10 bug fixes/improvements as outlined in the
> changelog:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12341386
>
> Tag:
> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_6_0_ALPHA_2
> Tag commit id: 3c37e8ce66613901f1b523b0519fb6ba51676270
>
> The artifacts to be voted on are located as follows (r23058).
> Source release:
> https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/sources
> Convenience binaries:
> https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/distribution
>
> Release artifacts are signed with a key from the following file:
> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>
> Please vote on releasing this package as Apache Groovy 2.6.0-alpha-2.
>
> The vote is open for the next 72 hours and passes if a majority of at least
> three +1 PMC votes are cast.
>
> [ ] +1 Release Apache Groovy 2.6.0-alpha-2
> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
> [ ] -1 Do not release Apache Groovy 2.6.0-alpha-2 because...
>
> Here is my vote:
>
> +1 (binding)
>
>
>
>
> --
> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html



--
Graeme Rocher



--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2

Guillaume Laforge
Administrator
But apart from this build-from-source issue, if I change the version of the plugin I mentioned below, then I can successfully build the project and run things like the Groovy console.

Guillaume

On Mon, Nov 13, 2017 at 9:58 AM, Guillaume Laforge <[hidden email]> wrote:
Hi,

I was trying to build from source with the source bundle, but it seems you can't generate the wrapper from a recent version of Gradle.
I have version 4.3.1, and when I try to launch gradle wrapper, to first create the appropriate wrapper, I get the following errors:

$ gradle wrapper


FAILURE: Build failed with an exception.


* Where:

Build file '/Users/glaforge/Downloads/groovy-2.6.0-alpha-2/build.gradle' line: 53


* What went wrong:

An exception occurred applying plugin request [id: 'com.gradle.build-scan', version: '1.6']

> Failed to apply plugin [id 'com.gradle.build-scan']

   > This version of Gradle requires version 1.8.0 of the build scan plugin or later.

     Please see https://gradle.com/scans/help/gradle-incompatible-plugin-version for more information.


* Try:

Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.


* Get more help at https://help.gradle.org


Which might also be why Cédric committed a change related to the build scan plugin?

Guillaume


On Sun, Nov 12, 2017 at 5:04 PM, Graeme Rocher <[hidden email]> wrote:
+1

On Sat, Nov 11, 2017 at 4:24 PM, Daniel.Sun <[hidden email]> wrote:
> Dear community,
>
> I am happy to start the VOTE thread for a Groovy 2.6.0-alpha-2 release!
>
> This release includes 10 bug fixes/improvements as outlined in the
> changelog:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12341386
>
> Tag:
> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_6_0_ALPHA_2
> Tag commit id: 3c37e8ce66613901f1b523b0519fb6ba51676270
>
> The artifacts to be voted on are located as follows (r23058).
> Source release:
> https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/sources
> Convenience binaries:
> https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/distribution
>
> Release artifacts are signed with a key from the following file:
> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>
> Please vote on releasing this package as Apache Groovy 2.6.0-alpha-2.
>
> The vote is open for the next 72 hours and passes if a majority of at least
> three +1 PMC votes are cast.
>
> [ ] +1 Release Apache Groovy 2.6.0-alpha-2
> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
> [ ] -1 Do not release Apache Groovy 2.6.0-alpha-2 because...
>
> Here is my vote:
>
> +1 (binding)
>
>
>
>
> --
> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html



--
Graeme Rocher



--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform




--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2

Daniel Sun
Hi Guillaume,

     Gradle 4+ does not support building Groovy well, so please check via
"gradlew clean dist"(note: use gradlew instead of gradle).

Cheers,
Daniel.Sun




--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2

Guillaume Laforge
Administrator
Hi Daniel,

I'm not building Groovy with Gradle 4+.
I only wanted to generate the wrapper with Gradle 4.3.1, which was the version I had installed locally.

As you know, we can't ship the wrapper with our source distribution.
And it means that someone with Gradle 4+ on his machine cannot build the source distribution out of the box.
But as I said in my other email, at least for the wrapper task generation, it was really just related to the problem with the plugin version.

Otherwise, we can indeed use Gradle 4.x to create the wrapper, and then use whichever version used by the wrapper properties, which is fine.

But as is, we can't build from source, since we can't generate the wrapper.
It's not a big showstopper, and I think we can proceed with the release, as otherwise, the convenience binaries or the custom-built (with the right build scan plugin version) is fine.

Hope this clarifies my point. Sorry if this wasn't clear.

Guillaume

On Mon, Nov 13, 2017 at 1:00 PM, Daniel Sun <[hidden email]> wrote:
Hi Guillaume,

     Gradle 4+ does not support building Groovy well, so please check via
"gradlew clean dist"(note: use gradlew instead of gradle).

Cheers,
Daniel.Sun



--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2

Daniel.Sun
Hi Guillaume,

      I've understood what you mean :-)

      As to the version of plugin, we can not satisfy everyone because
gradle 3+ and gradle 4+ requires different versions of plugin. So I sugguest
we should clarify the requirement of gradle version, which must be 3.5.1 to
generate the wrapper and build Apache Groovy from source.

       At last, I want to know, your vote is ?   ;-)


Cheers,
Daniel.Sun



--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2

Cédric Champeau
In reply to this post by Guillaume Laforge
You can use version 10.1.2 of the build scan plugin. But note that this is NOT specific to build scans. Any plugin applied that would be a bit old compared to the version that you use to generate the wrapper, would probably fail the build the same way: what we are doing is a dirty workaround for the fact (again) that the Gradle wrapper is not blessed by the foundation (it should, really). So what happens is that you use a much more recent version of a local install of Gradle, than the one the build accepts. And your version is of course _not_ compatible with the one that has been checked in in `wrapper.properties`. This is **exactly** why the wrapper exists and **must** be checked in the sources. So unless you install the very same version than the one defined in the wrapper.properties to generate the wrapper (which is pointless), you are in a danger zone that can fail. It has nothing to do with the build scan plugin. It is about build reproducibility. And I find it sad that we always have to fight to get this in.

2017-11-13 9:58 GMT+01:00 Guillaume Laforge <[hidden email]>:
Hi,

I was trying to build from source with the source bundle, but it seems you can't generate the wrapper from a recent version of Gradle.
I have version 4.3.1, and when I try to launch gradle wrapper, to first create the appropriate wrapper, I get the following errors:

$ gradle wrapper


FAILURE: Build failed with an exception.


* Where:

Build file '/Users/glaforge/Downloads/groovy-2.6.0-alpha-2/build.gradle' line: 53


* What went wrong:

An exception occurred applying plugin request [id: 'com.gradle.build-scan', version: '1.6']

> Failed to apply plugin [id 'com.gradle.build-scan']

   > This version of Gradle requires version 1.8.0 of the build scan plugin or later.

     Please see https://gradle.com/scans/help/gradle-incompatible-plugin-version for more information.


* Try:

Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.


* Get more help at https://help.gradle.org


Which might also be why Cédric committed a change related to the build scan plugin?

Guillaume


On Sun, Nov 12, 2017 at 5:04 PM, Graeme Rocher <[hidden email]> wrote:
+1

On Sat, Nov 11, 2017 at 4:24 PM, Daniel.Sun <[hidden email]> wrote:
> Dear community,
>
> I am happy to start the VOTE thread for a Groovy 2.6.0-alpha-2 release!
>
> This release includes 10 bug fixes/improvements as outlined in the
> changelog:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12341386
>
> Tag:
> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_6_0_ALPHA_2
> Tag commit id: 3c37e8ce66613901f1b523b0519fb6ba51676270
>
> The artifacts to be voted on are located as follows (r23058).
> Source release:
> https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/sources
> Convenience binaries:
> https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/distribution
>
> Release artifacts are signed with a key from the following file:
> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>
> Please vote on releasing this package as Apache Groovy 2.6.0-alpha-2.
>
> The vote is open for the next 72 hours and passes if a majority of at least
> three +1 PMC votes are cast.
>
> [ ] +1 Release Apache Groovy 2.6.0-alpha-2
> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
> [ ] -1 Do not release Apache Groovy 2.6.0-alpha-2 because...
>
> Here is my vote:
>
> +1 (binding)
>
>
>
>
> --
> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html



--
Graeme Rocher



--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform


Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2

Guillaume Laforge
Administrator
In reply to this post by Daniel.Sun
I'm voting +1

But let's get sure we can build from source the next time when someone has a recent version of Gradle installed locally.
At the very minimum, we should indicate in the README that we have to use some range of Gradle version for generating the wrapper in the first place.

On Mon, Nov 13, 2017 at 2:53 PM, Daniel.Sun <[hidden email]> wrote:
Hi Guillaume,

      I've understood what you mean :-)

      As to the version of plugin, we can not satisfy everyone because
gradle 3+ and gradle 4+ requires different versions of plugin. So I sugguest
we should clarify the requirement of gradle version, which must be 3.5.1 to
generate the wrapper and build Apache Groovy from source.

       At last, I want to know, your vote is ?   ;-)



--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2

Cédric Champeau
This will not always be possible. The source zip will live for years. You can only do this at release time, and there's nothing that guarantees that all plugins will all be compatible with the latest version of Gradle at the moment you release for a branch that uses an old version. It's just a miracle it works. Instead, let's make our point to the foundation: the wrapper MUST be endorsed.

2017-11-13 15:38 GMT+01:00 Guillaume Laforge <[hidden email]>:
I'm voting +1

But let's get sure we can build from source the next time when someone has a recent version of Gradle installed locally.
At the very minimum, we should indicate in the README that we have to use some range of Gradle version for generating the wrapper in the first place.

On Mon, Nov 13, 2017 at 2:53 PM, Daniel.Sun <[hidden email]> wrote:
Hi Guillaume,

      I've understood what you mean :-)

      As to the version of plugin, we can not satisfy everyone because
gradle 3+ and gradle 4+ requires different versions of plugin. So I sugguest
we should clarify the requirement of gradle version, which must be 3.5.1 to
generate the wrapper and build Apache Groovy from source.

       At last, I want to know, your vote is ?   ;-)



--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform


12