[VOTE] Release Apache Groovy 2.5.0-rc-3

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
20 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Groovy 2.5.0-rc-3

paulk_asert

Dear development community,

I am happy to start the VOTE thread for a Groovy 2.5.0-rc-3 release!

This release includes 27 bug fixes/improvements as outlined in the changelog:

Tag commit id: 6bff836d8373ff58f27f31106e9179eb4ab6b3ad

The artifacts to be voted on are located as follows (r27001).

Release artifacts are signed with a key from the following file:

Please vote on releasing this package as Apache Groovy 2.5.0-rc-3.

Reminder on ASF release approval requirements for PMC members:
Hints on validating checksums/signatures (but replace md5sum with sha256sum):

The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast.

[ ] +1 Release Apache Groovy 2.5.0-rc-3
[ ]  0 I don't have a strong opinion about this, but I assume it's ok
[ ] -1 Do not release Apache Groovy 2.5.0-rc-3 because...

Here is my vote:

+1 (binding)

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

jwagenleitner
+1 (binding)

On Sat, May 19, 2018 at 8:40 AM Paul King <[hidden email]> wrote:

Dear development community,

I am happy to start the VOTE thread for a Groovy 2.5.0-rc-3 release!

This release includes 27 bug fixes/improvements as outlined in the changelog:

Tag commit id: 6bff836d8373ff58f27f31106e9179eb4ab6b3ad

The artifacts to be voted on are located as follows (r27001).

Release artifacts are signed with a key from the following file:

Please vote on releasing this package as Apache Groovy 2.5.0-rc-3.

Reminder on ASF release approval requirements for PMC members:
Hints on validating checksums/signatures (but replace md5sum with sha256sum):

The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast.

[ ] +1 Release Apache Groovy 2.5.0-rc-3
[ ]  0 I don't have a strong opinion about this, but I assume it's ok
[ ] -1 Do not release Apache Groovy 2.5.0-rc-3 because...

Here is my vote:

+1 (binding)

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

Russel Winder-3
In reply to this post by paulk_asert

> [ ] +1 Release Apache Groovy 2.5.0-rc-3
> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
> [ ] -1 Do not release Apache Groovy 2.5.0-rc-3 because...
>
>

+1

--
Russel.
==========================================
Dr Russel Winder      t: +44 20 7585 2200
41 Buckmaster Road    m: +44 7770 465 077
London SW11 1EN, UK   w: www.russel.org.uk

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

Andres Almiray
+1

Sent from my primitive Tricorder

> On 20 May 2018, at 18:45, Russel Winder <[hidden email]> wrote:
>
>
>> [ ] +1 Release Apache Groovy 2.5.0-rc-3
>> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
>> [ ] -1 Do not release Apache Groovy 2.5.0-rc-3 because...
>>
>>
>
> +1
>
> --
> Russel.
> ==========================================
> Dr Russel Winder      t: +44 20 7585 2200
> 41 Buckmaster Road    m: +44 7770 465 077
> London SW11 1EN, UK   w: www.russel.org.uk
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

Daniel.Sun
In reply to this post by paulk_asert
+1

All tests pass on my machine. Here is my machine info:
```
------------------------------------------------------------
Gradle 4.7
------------------------------------------------------------

Build time:   2018-04-18 09:09:12 UTC
Revision:     b9a962bf70638332300e7f810689cb2febbd4a6c

Groovy:       2.4.12
Ant:          Apache Ant(TM) version 1.9.9 compiled on February 2 2017
JVM:          1.8.0_152 (Oracle Corporation 25.152-b16)
OS:           Windows 10 10.0 amd64
```

As a side note, the following test passes, but when running it in groovy
console, it failed...
```
        @groovy.transform.CompileStatic
        public class Foo<T extends List<X>, X extends Number> {
            X getFirstElement(T t) {
                X x = t.get(0)
                return x
            }
           
            static void main(String[] args) {
                def f = new Foo<ArrayList&lt;Integer>, Integer>()
                def list = new ArrayList<Integer>()
                list.add(123)
                assert 123 == f.getFirstElement(list)
            }
        }
```
(https://github.com/apache/groovy/blob/GROOVY_2_5_X/src/test/groovy/bugs/Groovy6171Bug.groovy#L58)

workaround:
```
        @groovy.transform.CompileStatic
        public class Foo<X extends Number, T extends List&lt;X>> {
            X getFirstElement(T t) {
                X x = t.get(0)
                return x
            }
           
            static void main(String[] args) {
                def f = new Foo<Integer, ArrayList&lt;Integer>>()
                def list = new ArrayList<Integer>()
                list.add(123)
                assert 123 == f.getFirstElement(list)
            }
        }
```


Cheers,
Daniel.Sun



--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
Daniel Sun
Apache Groovy committer

Blog: http://blog.sunlan.me
Twitter: @daniel_sun
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

Daniel.Sun
"GROOVY-6167" should be finally fixed by
1) fix resolving [1] (pushed just now, will be included in 2.5.0 GA)
2) fix type inference [2]

But it's really weird, I still don't know the reason why the test[3] always
passes...

P.S. The issue number should be 6167(not 6171), it is fixed by too


Cheers,
Daniel.Sun
[1]
https://github.com/apache/groovy/commit/29e68b7d99a1e41a73a5e33a5bb0d3b436d03b5f 
[2]
https://github.com/apache/groovy/commit/48807d5b1ba094e2f0dc212b6c92b4b370fe8394 
[3]
https://github.com/apache/groovy/blob/GROOVY_2_5_0_RC_3/src/test/groovy/bugs/Groovy6171Bug.groovy#L58-L71



--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
Daniel Sun
Apache Groovy committer

Blog: http://blog.sunlan.me
Twitter: @daniel_sun
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

Guillaume Laforge
Administrator
+1

Le dim. 20 mai 2018 à 18:30, Daniel.Sun <[hidden email]> a écrit :
"GROOVY-6167" should be finally fixed by
1) fix resolving [1] (pushed just now, will be included in 2.5.0 GA)
2) fix type inference [2]

But it's really weird, I still don't know the reason why the test[3] always
passes...

P.S. The issue number should be 6167(not 6171), it is fixed by too


Cheers,
Daniel.Sun
[1]
https://github.com/apache/groovy/commit/29e68b7d99a1e41a73a5e33a5bb0d3b436d03b5f
[2]
https://github.com/apache/groovy/commit/48807d5b1ba094e2f0dc212b6c92b4b370fe8394 
[3]
https://github.com/apache/groovy/blob/GROOVY_2_5_0_RC_3/src/test/groovy/bugs/Groovy6171Bug.groovy#L58-L71



--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

Jochen Theodorou
In reply to this post by paulk_asert
+1
On 19.05.2018 17:40, Paul King wrote:

>
> Dear development community,
>
> I am happy to start the VOTE thread for a Groovy 2.5.0-rc-3 release!
>
> This release includes 27 bug fixes/improvements as outlined in the
> changelog:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12343166
>
> Tag:
> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_5_0_RC_3
> Tag commit id: 6bff836d8373ff58f27f31106e9179eb4ab6b3ad
>
> The artifacts to be voted on are located as follows (r27001).
> Source release:
> https://dist.apache.org/repos/dist/dev/groovy/2.5.0-rc-3/sources
> Convenience binaries:
> https://dist.apache.org/repos/dist/dev/groovy/2.5.0-rc-3/distribution
>
> Release artifacts are signed with a key from the following file:
> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>
> Please vote on releasing this package as Apache Groovy 2.5.0-rc-3.
>
> Reminder on ASF release approval requirements for PMC members:
> http://www.apache.org/legal/release-policy.html#release-approval
> Hints on validating checksums/signatures (but replace md5sum with
> sha256sum):
> https://www.apache.org/info/verification.html
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release Apache Groovy 2.5.0-rc-3
> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
> [ ] -1 Do not release Apache Groovy 2.5.0-rc-3 because...
>
> Here is my vote:
>
> +1 (binding)
>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

paulk_asert
In reply to this post by Daniel.Sun

I suspect there is some stray "X" class on the test classpath which keeps the early checks happy until later resolution. Thanks for the fix.

Cheers, Paul.

On Mon, May 21, 2018 at 1:29 AM, Daniel.Sun <[hidden email]> wrote:
+1

All tests pass on my machine. Here is my machine info:
```
------------------------------------------------------------
Gradle 4.7
------------------------------------------------------------

Build time:   2018-04-18 09:09:12 UTC
Revision:     b9a962bf70638332300e7f810689cb2febbd4a6c

Groovy:       2.4.12
Ant:          Apache Ant(TM) version 1.9.9 compiled on February 2 2017
JVM:          1.8.0_152 (Oracle Corporation 25.152-b16)
OS:           Windows 10 10.0 amd64
```

As a side note, the following test passes, but when running it in groovy
console, it failed...
```
        @groovy.transform.CompileStatic
        public class Foo<T extends List<X>, X extends Number> {
            X getFirstElement(T t) {
                X x = t.get(0)
                return x
            }

            static void main(String[] args) {
                def f = new Foo<ArrayList&lt;Integer>, Integer>()
                def list = new ArrayList<Integer>()
                list.add(123)
                assert 123 == f.getFirstElement(list)
            }
        }
```
(https://github.com/apache/groovy/blob/GROOVY_2_5_X/src/test/groovy/bugs/Groovy6171Bug.groovy#L58)

workaround:
```
        @groovy.transform.CompileStatic
        public class Foo<X extends Number, T extends List&lt;X>> {
            X getFirstElement(T t) {
                X x = t.get(0)
                return x
            }

            static void main(String[] args) {
                def f = new Foo<Integer, ArrayList&lt;Integer>>()
                def list = new ArrayList<Integer>()
                list.add(123)
                assert 123 == f.getFirstElement(list)
            }
        }
```


Cheers,
Daniel.Sun



--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

Daniel.Sun
My pleasure :-)

P.S. You've collected more than three +1 from PMC members.

Cheers,
Daniel.Sun



--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
Daniel Sun
Apache Groovy committer

Blog: http://blog.sunlan.me
Twitter: @daniel_sun
12