[GitHub] groovy pull request #:

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] groovy pull request #:

asfgit
Github user jwagenleitner commented on the pull request:

    https://github.com/apache/groovy/commit/b1d1232770aade9672668df4dbc6aa2e2076fa9e#commitcomment-28988363
 
    In subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java:
    In subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java on line 3976:
    I think the method access should not be opened to satisfy a test. Usually `@TypeChecked` works similar to dynamic mode for method dispatch so accessing a protected method would normally be allowed. If `@TypeChecked` is changed to enforce visibility rules then maybe better to alter the test to use a sub-class so as to not have to change the access modifier here?


---