[GitHub] groovy pull request #753: GROOVY-8632: Groovy 2.5.0 fails to compile Google ...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] groovy pull request #753: GROOVY-8632: Groovy 2.5.0 fails to compile Google ...

asfgit
GitHub user jwagenleitner opened a pull request:

    https://github.com/apache/groovy/pull/753

    GROOVY-8632: Groovy 2.5.0 fails to compile Google Java Client sample code

    Class files can contain INNERCLASS references to other
    classes inner classes whose name may be the same name as a
    contained inner class. By storing modifiers in a map keyed
    by short class name there is a possibility for the wrong
    modifiers to be stored.
   
    Since generated class files for inner classes contain an INNERCLASS
    self reference, the logic can be simplified to look for a matching
    name and storing those access modifiers. This eliminates the need
    to search the outer class for the INNERCLASS reference.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jwagenleitner/groovy 8632-decompiled-cn-nested-classes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/753.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #753
   
----
commit 8b0d57cfc8c600296763b31a9d9f5166b17ef4f1
Author: John Wagenleitner <jwagenleitner@...>
Date:   2018-06-09T00:00:16Z

    GROOVY-8632: Groovy 2.5.0 fails to compile Google Java Client sample code
   
    Class files can contain INNERCLASS references to other
    classes inner classes whose name may be the same name as a
    contained inner class. By storing modifiers in a map keyed
    by short class name there is a possibility for the wrong
    modifiers to be stored.
   
    Since generated class files for inner classes contain an INNERCLASS
    self reference, the logic can be simplified to look for a matching
    name and storing those access modifiers. This eliminates the need
    to search the outer class for the INNERCLASS reference.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] groovy pull request #753: GROOVY-8632: Groovy 2.5.0 fails to compile Google ...

asfgit
Github user asfgit closed the pull request at:

    https://github.com/apache/groovy/pull/753


---