[GitHub] groovy pull request #661: Documentation: fix style-guide range example

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] groovy pull request #661: Documentation: fix style-guide range example

paulk-asert
GitHub user jja opened a pull request:

    https://github.com/apache/groovy/pull/661

    Documentation: fix style-guide range example

    e674d77 added more information about ranges
    but included erroneous code for `range.size()`.
   
    The style guide does not seem to have tests associated like some of the other
    docs. If you want me to create a test, please give me some guidance.
   
    I don't think code sample from e674d77 was tested. It was probably just
    an ad hoc example written on the fly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jja/groovy fix/style-guide-range

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/661.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #661
   
----
commit 20b34365a8cedca19b07be820ac3f4bf57926492
Author: John J. Allison <jja@...>
Date:   2018-02-08T17:06:22Z

    fix style-guide range example
   
    e674d77 added more information about ranges
    but included erroneous code for range.size().

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] groovy pull request #661: Documentation: fix style-guide range example

paulk-asert
Github user asfgit closed the pull request at:

    https://github.com/apache/groovy/pull/661


---