[GitHub] groovy pull request #615: AutoFinal: Added @AutoFinal(enabled=false) tests

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] groovy pull request #615: AutoFinal: Added @AutoFinal(enabled=false) tests

aalmiray-3
GitHub user mgroovy opened a pull request:

    https://github.com/apache/groovy/pull/615

    AutoFinal: Added @AutoFinal(enabled=false) tests

    Added assertAutoFinalTestScriptWithDisabledAnnotation to AutoFinalTransformBlackBoxTest, which checks for all test scripts that they compile in Groovy if the test script class is annotated with @AutoFinal(enabled=false) (i.e. the same as if no AutoFinal annotation was present)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mgroovy/groovy master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/615.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #615
   
----
commit 1f6157861498b99636899f706468bfd2c3ed3345
Author: mgroovy <[hidden email]>
Date:   2017-09-23T02:33:58Z

    [AutoFinal] ClassCodeVisitorSupport based (untested)

commit 56b6ab77146acc2132d9b55b0be9dc9bd64a316a
Author: mgroovy <[hidden email]>
Date:   2017-09-23T23:24:10Z

    Merge branch 'master' of https://github.com/apache/groovy

commit 95879085424aaf93a1497ba7ffa7df08cb606700
Author: mgroovy <[hidden email]>
Date:   2017-09-24T00:30:41Z

    optimized imports

commit 63d32d1b7f5db46d8cf2d170b69cc7b836227edc
Author: mgroovy <[hidden email]>
Date:   2017-09-24T12:21:15Z

    AutoFinalClosureASTTransformation#visitClosureExpression: Skip if expression.isSynthetic()

commit 858d2b1ab6275750ee453733c323559399cb008d
Author: mgroovy <[hidden email]>
Date:   2017-10-03T23:26:31Z

    AutoFinalClosureTransformTest; execute single test working

commit 0c232954e8ec03994b7590039d4ccd666780522b
Author: mgroovy <[hidden email]>
Date:   2017-10-03T23:27:49Z

    AutoFinalClosureTransformTest (WIP)

commit fa97c706be8ad28f651a9008e3dde978c38b228f
Author: mgroovy <[hidden email]>
Date:   2017-10-03T23:35:19Z

    AutoFinalClosureTransformTest: TestScript0.groovy: 26: The parameter [reversed] is declared final but is reassigned  :-)

commit f8d34722be7654816ec6b7b1bb8529b67c3c361a
Author: mgroovy <[hidden email]>
Date:   2017-10-03T23:53:10Z

    // 1) ASTTest explicitely checks for final modifier (which isn't put into bytecode)
            // 2) shouldNotCompile checks that the Groovy compiler responds in the expected way to an attempt at assigning a value to a method parameter

commit 6d42d852cf5a3cb4540681647e325728db16c14d
Author: mgroovy <[hidden email]>
Date:   2017-10-04T23:34:55Z

    AutoFinalClosure (WIP)

commit 87b873c1526da55937daf45b0d8cae2468f37f99
Author: mgroovy <[hidden email]>
Date:   2017-10-05T00:08:59Z

    AutoFinalClosureTransform_DEBUG: fix compilation NullPointerException (WIP)

commit cf80261b4aefa62cf2b2de805499e00c089ef657
Author: mgroovy <[hidden email]>
Date:   2017-10-05T20:49:48Z

    shouldThrow support

commit 08dbbe3bbee67f562d24f0cefeef9bef66798616
Author: mgroovy <[hidden email]>
Date:   2017-10-05T22:51:22Z

    AutoFinalClosureASTTransformation (WIP)

commit 6b9a839aac4f158bc22aed5c7f737491b2c805ad
Author: mgroovy <[hidden email]>
Date:   2017-10-06T00:14:32Z

    AutoFinalClosureASTTransformation

commit efba7d96dd98653c914b9dafd450a67de754595d
Author: mgroovy <[hidden email]>
Date:   2017-10-06T00:23:09Z

    WORKS:
    org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
    TestScriptnull0.groovy: 15: The parameter [s] is declared final but is reassigned
    . At [15:47]  @ line 15, column 47.
           final cls = { String s -> s = "abc";

commit 3df700f48efc10096db83fa33b577bb6f41ef28f
Author: mgroovy <[hidden email]>
Date:   2017-10-06T01:52:21Z

    AutoFinalClosureTransformTest: assert shouldNotCompile result

commit 3e72d865f1689bd23301ab3a577913c0c34ed609
Author: mgroovy <[hidden email]>
Date:   2017-10-06T02:17:06Z

    AutoFinalClosureTransformTest. assertAutoFinalTestScript(final String paramName, final List<String> classBodyTerms)

commit 8a28188c147ccd161b9c10441b703f37cd1e8492
Author: mgroovy <[hidden email]>
Date:   2017-10-06T13:51:45Z

    Merge AutoFinalClosureASTTransformation w AutoFinalASTTransformation (WIP)

commit b4191dc7599221ac6af16bc156ee83f3d0e28c65
Author: mgroovy <[hidden email]>
Date:   2017-10-06T14:27:46Z

    Merge AutoFinalClosureASTTransformation w AutoFinalASTTransformation (WIP)

commit 1dddb16606d7f942ab3de0a0d4464641fd2bddd0
Author: mgroovy <[hidden email]>
Date:   2017-10-06T14:29:07Z

    Merge AutoFinalClosureASTTransformation w AutoFinalASTTransformation (WIP)

commit fe874f0606ff8c5a952dc1c0f885350264d533b5
Author: mgroovy <[hidden email]>
Date:   2017-10-06T14:30:51Z

    Merge AutoFinalClosureASTTransformation w AutoFinalASTTransformation (WIP)

commit f4ad5abd6dda36b44543c5eee548719627613d5b
Author: mgroovy <[hidden email]>
Date:   2017-10-06T14:56:57Z

    Merge AutoFinalClosureASTTransformation w AutoFinalASTTransformation (WIP)

commit a25f4eb6eeef18dc92bbbd20f63b6025a8e3c11c
Author: mgroovy <[hidden email]>
Date:   2017-10-06T20:05:51Z

    Merge AutoFinalClosureASTTransformation w AutoFinalASTTransformation (WIP)

commit 8263f17c3ed22462d61d0a4f22af32d5427d90fa
Author: mgroovy <[hidden email]>
Date:   2017-10-06T20:07:24Z

    Merge AutoFinalClosureASTTransformation w AutoFinalASTTransformation (WIP)

commit 08c75a888161322c3230d7b94cf23d6df833f508
Author: mgroovy <[hidden email]>
Date:   2017-10-06T20:14:23Z

    Merge AutoFinalClosureASTTransformation w AutoFinalASTTransformation (WIP)

commit b9b5d5f6cb058c9b13f132933deeb3df0464294b
Author: mgroovy <[hidden email]>
Date:   2017-10-06T20:14:58Z

    Merge AutoFinalClosureASTTransformation w AutoFinalASTTransformation (WIP)

commit a09a3fc1ee05cc62a9d501ef6c49ed21193ab590
Author: mgroovy <[hidden email]>
Date:   2017-10-06T20:16:22Z

    Merge AutoFinalClosureASTTransformation w AutoFinalASTTransformation: extends AbstractASTTransformation works

commit 788897eaf6b1ac21983ac07fd007b2f6ea4e567d
Author: mgroovy <[hidden email]>
Date:   2017-10-06T20:25:31Z

    Merge AutoFinalClosureASTTransformation w AutoFinalASTTransformation (untested)

commit 0cab21a006af1102b38b7e4bbc37774990e83070
Author: mgroovy <[hidden email]>
Date:   2017-10-06T20:42:55Z

    Merge AutoFinalClosureASTTransformation w AutoFinalASTTransformation working

commit 3d159677c48a90a4513c368e1f22f5ad71ea2c50
Author: mgroovy <[hidden email]>
Date:   2017-10-06T21:05:25Z

    Replace AutoFinalASTTransformation w AutoFinalClosureASTTransformation (WIP)

commit 8e357f3ad1341f8390fa2c4a7884749695e8427a
Author: mgroovy <[hidden email]>
Date:   2017-10-06T21:08:08Z

    Replace AutoFinalASTTransformation w AutoFinalClosureASTTransformation done

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] groovy pull request #615: @AutoFinal: Added @AutoFinal(enabled=false) tests

aalmiray-3
Github user asfgit closed the pull request at:

    https://github.com/apache/groovy/pull/615


---