[GitHub] groovy pull request #575: cache GroovyRunnerRegistry values

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] groovy pull request #575: cache GroovyRunnerRegistry values

paulk-asert
GitHub user jwagenleitner opened a pull request:

    https://github.com/apache/groovy/pull/575

    cache GroovyRunnerRegistry values

    The registry should be read heavy and most use made of the iterator.  Few writes/loads should occur, so values should be cached in order to optimize iteration.
   
    Benchmarked the change against using a read lock but `volatile` was significantly faster.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jwagenleitner/groovy runner-values

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/575.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #575
   
----
commit 28576c8da816a970d3a1151744f6b073f374e9a4
Author: John Wagenleitner <[hidden email]>
Date:   2017-07-15T14:00:29Z

    cache GroovyRunnerRegistry values
   
    The registry should be read heavy and most use made of the
    iterator.  Few writes/loads should occur, so values should
    be cached in order to optimize iteration.

commit 43b26fd640a1867c557681d4381113a974cce680
Author: John Wagenleitner <[hidden email]>
Date:   2017-07-17T01:33:20Z

    GroovyRunnerRegistry iterator benchmarks

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] groovy pull request #575: cache GroovyRunnerRegistry values

paulk-asert
Github user asfgit closed the pull request at:

    https://github.com/apache/groovy/pull/575


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---