[GitHub] groovy pull request #560: GROOVY-8226: JSR308 initial plumbing tweaks

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] groovy pull request #560: GROOVY-8226: JSR308 initial plumbing tweaks

danielsun1106
GitHub user paulk-asert opened a pull request:

    https://github.com/apache/groovy/pull/560

    GROOVY-8226: JSR308 initial plumbing tweaks

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paulk-asert/groovy groovy8226

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/560.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #560
   
----
commit 08baa07eedbd7962d637782ddb0b5654d1fc6516
Author: paulk <[hidden email]>
Date:   2017-06-12T10:10:50Z

    GROOVY-8226: JSR308 initial plumbing tweaks

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] groovy pull request #560: GROOVY-8226: JSR308 initial plumbing tweaks

danielsun1106
Github user jwagenleitner commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/560#discussion_r121416370
 
    --- Diff: src/main/org/codehaus/groovy/vmplugin/vm8/Java8.java ---
    @@ -51,4 +53,13 @@ public int getVersion() {
             return 8;
         }
     
    +    protected int getElementCode(ElementType value) {
    --- End diff --
   
    might be good to have `@Override`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] groovy pull request #560: GROOVY-8226: JSR308 initial plumbing tweaks

danielsun1106
In reply to this post by danielsun1106
Github user paulk-asert commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/560#discussion_r121667932
 
    --- Diff: src/main/org/codehaus/groovy/vmplugin/vm8/Java8.java ---
    @@ -51,4 +53,13 @@ public int getVersion() {
             return 8;
         }
     
    +    protected int getElementCode(ElementType value) {
    --- End diff --
   
    done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] groovy pull request #560: GROOVY-8226: JSR308 initial plumbing tweaks

danielsun1106
In reply to this post by danielsun1106
Github user asfgit closed the pull request at:

    https://github.com/apache/groovy/pull/560


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...