Quantcast

[GitHub] groovy pull request #521: GROOVY-7879 Groovy calls wrong method if there is ...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] groovy pull request #521: GROOVY-7879 Groovy calls wrong method if there is ...

jwagenleitner-3
GitHub user dkhamitov opened a pull request:

    https://github.com/apache/groovy/pull/521

    GROOVY-7879 Groovy calls wrong method if there is a static method on …

    Hi guys, can we consider a small kind of tactical fix (imho) to GROOVY-7879 or is it a bad idea/solution? It fixes the situation when we have:
    ```java
    interface Foo {
        static String foo() {
            return "I'm Foo";
        }
    }
   
    class Bar implements Foo {
        static String foo() {
            return "I'm Bar";
        }
    }
    ```
    but assert fails:
    ```java
    assert Bar.foo() == "I'm Bar" //Output: I'm Foo
    ```
    This pull request is for the parrot branch because static methods on interfaces were introduced in Java 8

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dkhamitov/groovy GROOVY-7879-wrong-static-method

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/521.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #521
   
----
commit 07ba4cb300d0b26ff5742b4a11d5b164b688c381
Author: Dmitrii Kahmitov <[hidden email]>
Date:   2017-04-05T06:49:54Z

    GROOVY-7879 Groovy calls wrong method if there is a static method on an interface

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] groovy pull request #521: GROOVY-7879 Groovy calls wrong method if there is ...

jwagenleitner-3
Github user asfgit closed the pull request at:

    https://github.com/apache/groovy/pull/521


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...