[GitHub] [groovy] paulk-asert opened a new pull request #1421: GROOVY-9819: bump jsp-api/servlet-api versions to 2.3.3/4.0.1

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [groovy] paulk-asert opened a new pull request #1421: GROOVY-9819: bump jsp-api/servlet-api versions to 2.3.3/4.0.1

GitBox

paulk-asert opened a new pull request #1421:
URL: https://github.com/apache/groovy/pull/1421


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [groovy] veita commented on pull request #1421: GROOVY-9819: bump jsp-api/servlet-api versions to 2.3.3/4.0.1

GitBox

veita commented on pull request #1421:
URL: https://github.com/apache/groovy/pull/1421#issuecomment-729515088


   Would this be the right place to fix https://issues.apache.org/jira/browse/GROOVY-9818?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [groovy] paulk-asert commented on pull request #1421: GROOVY-9819: bump jsp-api/servlet-api versions to 2.3.3/4.0.1

GitBox
In reply to this post by GitBox

paulk-asert commented on pull request #1421:
URL: https://github.com/apache/groovy/pull/1421#issuecomment-729644917


   It is indeed related. Both the JSP and servlet api license files are missing for Groovy 3. For Groovy 4, we have a revamped build and it doesn't bundle those jars in the zip (revamped after 4.0.0-alpha-1 was released). You can think of this as better honoring the intended "provided" status of those jars in Groovy 3. But I am still working things through, so things might change. I suspect I will keep this issue separate and fix the license files (for these new versions) in Groovy 3 - probably under the GROOVY-9818 issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [groovy] asfgit closed pull request #1421: GROOVY-9819: bump jsp-api/servlet-api versions to 2.3.3/4.0.1

GitBox
In reply to this post by GitBox

asfgit closed pull request #1421:
URL: https://github.com/apache/groovy/pull/1421


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [groovy] asfgit merged pull request #1421: GROOVY-9819: bump jsp-api/servlet-api versions to 2.3.3/4.0.1

GitBox
In reply to this post by GitBox

asfgit merged pull request #1421:
URL: https://github.com/apache/groovy/pull/1421


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [groovy] paulk-asert commented on pull request #1421: GROOVY-9819: bump jsp-api/servlet-api versions to 2.3.3/4.0.1

GitBox
In reply to this post by GitBox

paulk-asert commented on pull request #1421:
URL: https://github.com/apache/groovy/pull/1421#issuecomment-731140096


   Proposed PR merged.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]