[GitHub] [groovy] danielsun1106 opened a new pull request #1205: GROOVY-9480: New v9 ClassFinder throws NoSuchFileException/Unsupporte

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [groovy] danielsun1106 opened a new pull request #1205: GROOVY-9480: New v9 ClassFinder throws NoSuchFileException/Unsupporte

GitBox
danielsun1106 opened a new pull request #1205: GROOVY-9480: New v9 ClassFinder throws NoSuchFileException/Unsupporte…
URL: https://github.com/apache/groovy/pull/1205
 
 
   …dOperationException and writes it to stderr

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [groovy] paulk-asert commented on issue #1205: GROOVY-9480: New v9 ClassFinder throws NoSuchFileException/Unsupporte

GitBox
paulk-asert commented on issue #1205: GROOVY-9480: New v9 ClassFinder throws NoSuchFileException/Unsupporte…
URL: https://github.com/apache/groovy/pull/1205#issuecomment-604172965
 
 
   +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [groovy] danielsun1106 merged pull request #1205: GROOVY-9480: New v9 ClassFinder throws NoSuchFileException/Unsupporte

GitBox
In reply to this post by GitBox
danielsun1106 merged pull request #1205: GROOVY-9480: New v9 ClassFinder throws NoSuchFileException/Unsupporte…
URL: https://github.com/apache/groovy/pull/1205
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [groovy] eric-milles commented on issue #1205: GROOVY-9480: New v9 ClassFinder throws NoSuchFileException/Unsupporte

GitBox
In reply to this post by GitBox
eric-milles commented on issue #1205: GROOVY-9480: New v9 ClassFinder throws NoSuchFileException/Unsupporte…
URL: https://github.com/apache/groovy/pull/1205#issuecomment-604423390
 
 
   Not sure I agree with this change.  I filed the bug because the exception was coming for 1) trying to close a file system handle that does not support it and 2) tyring to find "groovy" in the root of a project that does not have such a directory.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [groovy] paulk-asert commented on issue #1205: GROOVY-9480: New v9 ClassFinder throws NoSuchFileException/Unsupporte

GitBox
In reply to this post by GitBox
paulk-asert commented on issue #1205: GROOVY-9480: New v9 ClassFinder throws NoSuchFileException/Unsupporte…
URL: https://github.com/apache/groovy/pull/1205#issuecomment-604458024
 
 
   @eric-milles Do you have a reproducer for those cases?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [groovy] eric-milles commented on issue #1205: GROOVY-9480: New v9 ClassFinder throws NoSuchFileException/Unsupporte

GitBox
In reply to this post by GitBox
eric-milles commented on issue #1205: GROOVY-9480: New v9 ClassFinder throws NoSuchFileException/Unsupporte…
URL: https://github.com/apache/groovy/pull/1205#issuecomment-604489594
 
 
   In my environment, `org.codehaus.groovy.vmplugin.v9.Java9#getDefaultImportClasses` is called and its request `DefaultGroovyMethods.getLocation(gcl.loadClass("groovy.grape.GrapeIvy")).toURI()` returns:
   ```
   file:/C:/Users/.../org.codehaus.groovy30/
   ```
   
   `getDefaultImportClasses` makes the assumption that the URI returned will then have a "groovy" package under it.  And that's just not how the class loader that provides a GrapeIvy class works in my environment.
   
   This is a different flavor of the existing note "in production environment, groovy-core classes, e.g. `GroovySystem`(java class) and `GrapeIvy`(groovy class) are all packaged in the groovy-core jar file, but in Groovy development environment, groovy-core classes are distributed in different directories".
   
   Also, you cannot assume that in production they are sourced from the same archive since you could use the patch modules feature of JPMS or OSGi to add classes from another archive.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services