CLiBuilder + JIRA-1266

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
14 messages Options
12
tog
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

CLiBuilder + JIRA-1266

tog
Hi there,

Here is a patch that solve cliBuilder problems and JIRA1266. I could have commit but I would prefer Dierk & Jochen to review it especially the CliBuilder stuff
cheers
tog
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RE: CLiBuilder + JIRA-1266

Dierk König
Hi tog,
 
in case you attached the patch to this mail: the server stripped it off.
You better attach it to issue itself.
If that's http://jira.codehaus.org/browse/GROOVY-1266 'ant too chatty' it probably doesn't need review.
Even with CliBuilder I'd suggest you go ahead and commit.
In the worst case we could revert at any time, although I don't think that's necessary :-)
What was the problem with it and what is you patch doing?
 
cheers
Mittie
-----Original Message-----
From: tog [mailto:[hidden email]]
Sent: Samstag, 11. März 2006 12:25
To: [hidden email]
Subject: [groovy-dev] CLiBuilder + JIRA-1266

Hi there,

Here is a patch that solve cliBuilder problems and JIRA1266. I could have commit but I would prefer Dierk & Jochen to review it especially the CliBuilder stuff
cheers
tog
tog
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: CLiBuilder + JIRA-1266

tog
Hi Mittie,

On 3/11/06, Dierk Koenig <[hidden email]> wrote:
Hi tog,
 
in case you attached the patch to this mail: the server stripped it off.
You better attach it to issue itself.
If that's <a href="http://jira.codehaus.org/browse/GROOVY-1266" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://jira.codehaus.org/browse/GROOVY-1266 'ant too chatty' it probably doesn't need review.

Here it is only:
 -            log("statements executed successfully");
+            log("statements executed successfully", Project.MSG_VERBOSE);h

Even with CliBuilder I'd suggest you go ahead and commit.
In the worst case we could revert at any time, although I don't think that's necessary :-)

héhé ... take a look below I will commit after your ok ;-)

What was the problem with it and what is you patch doing?

Well, I took the source code of  HelpFormatter  and noticed  that 
   width is now defaultWidth,
   leftPadding is now defaultLeftPad
   ...

and I modified some values checked in CliBuilderTest.groovy.

cheers
tog

cheers
Mittie
-----Original Message-----
From: tog [mailto:[hidden email]]
Sent: Samstag, 11. März 2006 12:25
To: [hidden email]
Subject: [groovy-dev] CLiBuilder + JIRA-1266

Hi there,

Here is a patch that solve cliBuilder problems and JIRA1266. I could have commit but I would prefer Dierk & Jochen to review it especially the CliBuilder stuff
cheers
tog

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RE: CLiBuilder + JIRA-1266

Dierk König
Hi,
-----Original Message-----
From: tog [mailto:[hidden email]]
Sent: Samstag, 11. März 2006 16:43
To: [hidden email]
Subject: Re: [groovy-dev] CLiBuilder + JIRA-1266

Hi Mittie,

On 3/11/06, Dierk Koenig <[hidden email]> wrote:
Hi tog,
 
in case you attached the patch to this mail: the server stripped it off.
You better attach it to issue itself.
If that's <A onclick="return top.js.OpenExtLink(window,event,this)" href="http://jira.codehaus.org/browse/GROOVY-1266" target=_blank>http://jira.codehaus.org/browse/GROOVY-1266 'ant too chatty' it probably doesn't need review.

Here it is only:
 -            log("statements executed successfully");
+            log("statements executed successfully", Project.MSG_VERBOSE);h 
 
That's all fine (trailing 'h' probably doesn't belong here). 

Even with CliBuilder I'd suggest you go ahead and commit.
In the worst case we could revert at any time, although I don't think that's necessary :-)

héhé ... take a look below I will commit after your ok ;-)

What was the problem with it and what is you patch doing?

Well, I took the source code of  HelpFormatter  and noticed  that 
   width is now defaultWidth,
   leftPadding is now defaultLeftPad  
 
Interesting. That's not in my codebase. Are the old methods deprecated
but still there? -> I'd like to avoid having breaks now the other way around.
 
   ...

and I modified some values checked in CliBuilderTest.groovy. 
 
Good job.
Mittie 

cheers
tog

cheers
Mittie
-----Original Message-----
From: tog [mailto:[hidden email]]
Sent: Samstag, 11. März 2006 12:25
To: [hidden email]
Subject: [groovy-dev] CLiBuilder + JIRA-1266

Hi there,

Here is a patch that solve cliBuilder problems and JIRA1266. I could have commit but I would prefer Dierk & Jochen to review it especially the CliBuilder stuff
cheers
tog

tog
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: CLiBuilder + JIRA-1266

tog


Well, I took the source code of  HelpFormatter  and noticed  that 
   width is now defaultWidth,
   leftPadding is now defaultLeftPad  
 
Interesting. That's not in my codebase. Are the old methods deprecated
but still there? -> I'd like to avoid having breaks now the other way around.

Hum, which methods are you referring to, these are public fields there is no setter
nor getters on these fields.
cheers
tog

   ...

and I modified some values checked in CliBuilderTest.groovy. 
 
Good job.
Mittie 

cheers
tog

cheers
Mittie
-----Original Message-----
From: tog [mailto:[hidden email]]
Sent: Samstag, 11. März 2006 12:25
To: [hidden email]
Subject: [groovy-dev] CLiBuilder + JIRA-1266

Hi there,

Here is a patch that solve cliBuilder problems and JIRA1266. I could have commit but I would prefer Dierk & Jochen to review it especially the CliBuilder stuff
cheers
tog


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RE: CLiBuilder + JIRA-1266

Dierk König
Here is my code decompiled from the commons-cli-1.0.jar that comes with Groovy:
 

    public HelpFormatter() { /* compiled code */ }
 
    public void setWidth(int i) { /* compiled code */ }
 
    public int getWidth() { /* compiled code */ }

    public void setLeftPadding(int i) { /* compiled code */ }
 
    public int getLeftPadding() { /* compiled code */ }
 
i.e. formatter.width  and formatter.leftPadding should work just fine.
Note: CliBuilder is groovy, not Java source.
 
If on your machine, it works with fields but not with method-based
properties, then we have a different issue -> blackdrag?
 
cheers
Mittie
 
 
-----Original Message-----
From: tog [mailto:[hidden email]]
Sent: Samstag, 11. März 2006 17:31
To: [hidden email]
Subject: Re: [groovy-dev] CLiBuilder + JIRA-1266



Well, I took the source code of  HelpFormatter  and noticed  that 
   width is now defaultWidth,
   leftPadding is now defaultLeftPad  
 
Interesting. That's not in my codebase. Are the old methods deprecated
but still there? -> I'd like to avoid having breaks now the other way around.

Hum, which methods are you referring to, these are public fields there is no setter
nor getters on these fields.
cheers
tog

   ...

and I modified some values checked in CliBuilderTest.groovy. 
 
Good job.
Mittie 

cheers
tog

cheers
Mittie
-----Original Message-----
From: tog [mailto:[hidden email]]
Sent: Samstag, 11. März 2006 12:25
To: [hidden email]
Subject: [groovy-dev] CLiBuilder + JIRA-1266

Hi there,

Here is a patch that solve cliBuilder problems and JIRA1266. I could have commit but I would prefer Dierk & Jochen to review it especially the CliBuilder stuff
cheers
tog


tog
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: CLiBuilder + JIRA-1266

tog
héhé,
When you said come with Groovy ... is this the one downloaded by maven ?
Mine, when decompiled, does not show these setter/getter but is the same
as the source I got from Apache ....

Should you try a new install from scratch and remove commons-cli from your
maven repos ?

cheers
tog

On 3/11/06, Dierk Koenig <[hidden email]> wrote:
Here is my code decompiled from the commons-cli-1.0.jar that comes with Groovy:
 

    public HelpFormatter() { /* compiled code */ }
 
    public void setWidth(int i) { /* compiled code */ }
 
    public int getWidth() { /* compiled code */ }

    public void setLeftPadding(int i) { /* compiled code */ }
 
    public int getLeftPadding() { /* compiled code */ }
 
i.e. formatter.width  and formatter.leftPadding should work just fine.
Note: CliBuilder is groovy, not Java source.
 
If on your machine, it works with fields but not with method-based
properties, then we have a different issue -> blackdrag?
 
cheers
Mittie
 
 
-----Original Message-----
From: tog [mailto:[hidden email]]
Sent: Samstag, 11. März 2006 17:31
To: [hidden email]
Subject: Re: [groovy-dev] CLiBuilder + JIRA-1266



Well, I took the source code of  HelpFormatter  and noticed  that 
   width is now defaultWidth,
   leftPadding is now defaultLeftPad  
 
Interesting. That's not in my codebase. Are the old methods deprecated
but still there? -> I'd like to avoid having breaks now the other way around.

Hum, which methods are you referring to, these are public fields there is no setter
nor getters on these fields.
cheers
tog

   ...

and I modified some values checked in CliBuilderTest.groovy. 
 
Good job.
Mittie 

cheers
tog

cheers
Mittie
-----Original Message-----
From: tog [mailto:[hidden email]]
Sent: Samstag, 11. März 2006 12:25
To: [hidden email]
Subject: [groovy-dev] CLiBuilder + JIRA-1266

Hi there,

Here is a patch that solve cliBuilder problems and JIRA1266. I could have commit but I would prefer Dierk & Jochen to review it especially the CliBuilder stuff
cheers
tog



Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RE: CLiBuilder + JIRA-1266

Dierk König
Hmpf.
That's from my %GROOVY_HOME%/lib dir.
 
Hard to believe ibilio hosts a different one under the same name, but I'll try.
But even if it is. Which one is correct then? Yours or mine? ;-)
I mean, it will break on other machine for the same reason.
 
we'll see
Mittie
-----Original Message-----
From: tog [mailto:[hidden email]]
Sent: Samstag, 11. März 2006 19:20
To: [hidden email]
Subject: Re: [groovy-dev] CLiBuilder + JIRA-1266

héhé,
When you said come with Groovy ... is this the one downloaded by maven ?
Mine, when decompiled, does not show these setter/getter but is the same
as the source I got from Apache ....

Should you try a new install from scratch and remove commons-cli from your
maven repos ?

cheers
tog

On 3/11/06, Dierk Koenig <[hidden email]> wrote:
Here is my code decompiled from the commons-cli-1.0.jar that comes with Groovy:
 

    public HelpFormatter() { /* compiled code */ }
 
    public void setWidth(int i) { /* compiled code */ }
 
    public int getWidth() { /* compiled code */ }

    public void setLeftPadding(int i) { /* compiled code */ }
 
    public int getLeftPadding() { /* compiled code */ }
 
i.e. formatter.width  and formatter.leftPadding should work just fine.
Note: CliBuilder is groovy, not Java source.
 
If on your machine, it works with fields but not with method-based
properties, then we have a different issue -> blackdrag?
 
cheers
Mittie
 
 
-----Original Message-----
From: tog [mailto:[hidden email]]
Sent: Samstag, 11. März 2006 17:31
To: [hidden email]
Subject: Re: [groovy-dev] CLiBuilder + JIRA-1266



Well, I took the source code of  HelpFormatter  and noticed  that 
   width is now defaultWidth,
   leftPadding is now defaultLeftPad  
 
Interesting. That's not in my codebase. Are the old methods deprecated
but still there? -> I'd like to avoid having breaks now the other way around.

Hum, which methods are you referring to, these are public fields there is no setter
nor getters on these fields.
cheers
tog

   ...

and I modified some values checked in CliBuilderTest.groovy. 
 
Good job.
Mittie 

cheers
tog

cheers
Mittie
-----Original Message-----
From: tog [mailto:[hidden email]]
Sent: Samstag, 11. März 2006 12:25
To: [hidden email]
Subject: [groovy-dev] CLiBuilder + JIRA-1266

Hi there,

Here is a patch that solve cliBuilder problems and JIRA1266. I could have commit but I would prefer Dierk & Jochen to review it especially the CliBuilder stuff
cheers
tog



tog
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: CLiBuilder + JIRA-1266

tog


On 3/11/06, Dierk Koenig <[hidden email]> wrote:
Hmpf.
That's from my %GROOVY_HOME%/lib dir.
 
Hard to believe ibilio hosts a different one under the same name, but I'll try.
But even if it is. Which one is correct then? Yours or mine? ;-)

Mine of course ;-)
Seriously, I check the version on my machine and compared it with the one available
from the Apache site, they are the same. So I am pretty confident in that one.

I compared also with the one coming with JSR05, it is the same.
So I really don't undrestand !!! 

But that's true that on my machine I have the same problem as the one reported on the
mailing list ... so my patch ;-)

cheers
tog

I mean, it will break on other machine for the same reason.
 
we'll see
Mittie
-----Original Message-----
From: tog [mailto:[hidden email]]
Sent: Samstag, 11. März 2006 19:20
To: [hidden email]
Subject: Re: [groovy-dev] CLiBuilder + JIRA-1266

héhé,
When you said come with Groovy ... is this the one downloaded by maven ?
Mine, when decompiled, does not show these setter/getter but is the same
as the source I got from Apache ....

Should you try a new install from scratch and remove commons-cli from your
maven repos ?

cheers
tog

On 3/11/06, Dierk Koenig <[hidden email]> wrote:
Here is my code decompiled from the commons-cli-1.0.jar that comes with Groovy:
 

    public HelpFormatter() { /* compiled code */ }
 
    public void setWidth(int i) { /* compiled code */ }
 
    public int getWidth() { /* compiled code */ }

    public void setLeftPadding(int i) { /* compiled code */ }
 
    public int getLeftPadding() { /* compiled code */ }
 
i.e. formatter.width  and formatter.leftPadding should work just fine.
Note: CliBuilder is groovy, not Java source.
 
If on your machine, it works with fields but not with method-based
properties, then we have a different issue -> blackdrag?
 
cheers
Mittie
 
 
-----Original Message-----
From: tog [mailto:[hidden email]]
Sent: Samstag, 11. März 2006 17:31
To: [hidden email]
Subject: Re: [groovy-dev] CLiBuilder + JIRA-1266



Well, I took the source code of  HelpFormatter  and noticed  that 
   width is now defaultWidth,
   leftPadding is now defaultLeftPad  
 
Interesting. That's not in my codebase. Are the old methods deprecated
but still there? -> I'd like to avoid having breaks now the other way around.

Hum, which methods are you referring to, these are public fields there is no setter
nor getters on these fields.
cheers
tog

   ...

and I modified some values checked in CliBuilderTest.groovy. 
 
Good job.
Mittie 

cheers
tog

cheers
Mittie
-----Original Message-----
From: tog [mailto:[hidden email]]
Sent: Samstag, 11. März 2006 12:25
To: [hidden email]
Subject: [groovy-dev] CLiBuilder + JIRA-1266

Hi there,

Here is a patch that solve cliBuilder problems and JIRA1266. I could have commit but I would prefer Dierk & Jochen to review it especially the CliBuilder stuff
cheers
tog




Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RE: CLiBuilder + JIRA-1266

Dierk König
ok, I checked and you are right.
There are two versions of commons-cli-1.0.jar !!!!!
Even with incompatible API !!!!!
 
My last one from ibiblio was from Sept 04.
 
Good news: you can commit !
 
Bad news:
All others where the old version worked, like e.g. blackdrag need to delete the
old version to make the build running again after your change.
 
I still cannot believe it.
Mittie
-----Original Message-----
From: tog [mailto:[hidden email]]
Sent: Samstag, 11. März 2006 19:59
To: [hidden email]
Subject: Re: [groovy-dev] CLiBuilder + JIRA-1266



On 3/11/06, Dierk Koenig <[hidden email]> wrote:
Hmpf.
That's from my %GROOVY_HOME%/lib dir.
 
Hard to believe ibilio hosts a different one under the same name, but I'll try.
But even if it is. Which one is correct then? Yours or mine? ;-)

Mine of course ;-)
Seriously, I check the version on my machine and compared it with the one available
from the Apache site, they are the same. So I am pretty confident in that one.

I compared also with the one coming with JSR05, it is the same.
So I really don't undrestand !!! 

But that's true that on my machine I have the same problem as the one reported on the
mailing list ... so my patch ;-)

cheers
tog

I mean, it will break on other machine for the same reason.
 
we'll see
Mittie
-----Original Message-----
From: tog [mailto:[hidden email]]
Sent: Samstag, 11. März 2006 19:20
To: [hidden email]
Subject: Re: [groovy-dev] CLiBuilder + JIRA-1266

héhé,
When you said come with Groovy ... is this the one downloaded by maven ?
Mine, when decompiled, does not show these setter/getter but is the same
as the source I got from Apache ....

Should you try a new install from scratch and remove commons-cli from your
maven repos ?

cheers
tog

On 3/11/06, Dierk Koenig <[hidden email]> wrote:
Here is my code decompiled from the commons-cli-1.0.jar that comes with Groovy:
 

    public HelpFormatter() { /* compiled code */ }
 
    public void setWidth(int i) { /* compiled code */ }
 
    public int getWidth() { /* compiled code */ }

    public void setLeftPadding(int i) { /* compiled code */ }
 
    public int getLeftPadding() { /* compiled code */ }
 
i.e. formatter.width  and formatter.leftPadding should work just fine.
Note: CliBuilder is groovy, not Java source.
 
If on your machine, it works with fields but not with method-based
properties, then we have a different issue -> blackdrag?
 
cheers
Mittie
 
 
-----Original Message-----
From: tog [mailto:[hidden email]]
Sent: Samstag, 11. März 2006 17:31
To: [hidden email]
Subject: Re: [groovy-dev] CLiBuilder + JIRA-1266



Well, I took the source code of  HelpFormatter  and noticed  that 
   width is now defaultWidth,
   leftPadding is now defaultLeftPad  
 
Interesting. That's not in my codebase. Are the old methods deprecated
but still there? -> I'd like to avoid having breaks now the other way around.

Hum, which methods are you referring to, these are public fields there is no setter
nor getters on these fields.
cheers
tog

   ...

and I modified some values checked in CliBuilderTest.groovy. 
 
Good job.
Mittie 

cheers
tog

cheers
Mittie
-----Original Message-----
From: tog [mailto:[hidden email]]
Sent: Samstag, 11. März 2006 12:25
To: [hidden email]
Subject: [groovy-dev] CLiBuilder + JIRA-1266

Hi there,

Here is a patch that solve cliBuilder problems and JIRA1266. I could have commit but I would prefer Dierk & Jochen to review it especially the CliBuilder stuff
cheers
tog




12
Loading...