[CANCEL][VOTE] Release Apache Groovy 2.4.10

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
13 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[CANCEL][VOTE] Release Apache Groovy 2.4.10

paulk_asert
Okay, I am going to cancel the vote and try again with the commit
removed for the issue John found. I'll have to work out why one of my
CI builds didn't trigger that error.

I'll start a new vote shortly. Cédric/Guillaume, I'm keen for any
further feedback on why you were having issues with the 'dist' task.
That remains unexplained and unreproducible from my end.

Cheers, Paul.

On Mon, Mar 13, 2017 at 5:16 PM, Paul King <[hidden email]> wrote:

> Hi John,
>
> I did a bit more testing for the non-spock case and perhaps there is
> an issue there. I'll see if Jochen or Cédric have a little more
> knowledge on whether that case should be allowed. Certainly some paths
> give you ClassFormatError with the dot in the name but there seems to
> be other paths which may not depending on how you run it - like the
> test you showed.
>
> Cheers, Paul.
>
> On Mon, Mar 13, 2017 at 10:38 AM, Paul King <[hidden email]> wrote:
>> Hi John, the Spock example is fine since that isn't left as the method
>> name by the time the test is run. I am puzzled how the other one could
>> have ever run.
>>
>> Cheers, Paul.
>>
>> On Sun, Mar 12, 2017 at 9:28 AM, John Wagenleitner
>> <[hidden email]> wrote:
>>> +1
>>>
>>> Just wanted to note that in testing I came across some method names in tests
>>> that had characters that are now no longer allowed in method names [1] [2].
>>> I know this is related to the fix for GROOVY-6792, just thought it was odd
>>> that it seems to have worked in some cases before.
>>>
>>> [1]
>>> https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-test-suite-web/src/test/groovy/org/grails/web/codecs/CodecSpec.groovy#L40
>>>
>>> [2]
>>> https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-core/src/test/groovy/org/grails/compiler/injection/DefaultDomainClassInjectorSpec.groovy#L17
>>>
>>> On Thu, Mar 9, 2017 at 2:29 PM, Paul King <[hidden email]> wrote:
>>>>
>>>> Dear community,
>>>>
>>>> I am happy to start the VOTE thread for a Groovy 2.4.10 release!
>>>>
>>>> This release includes 9 bug fixes/improvements as outlined in the
>>>> changelog:
>>>>
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12339743
>>>>
>>>> Tag:
>>>> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_4_10
>>>> Tag commit id: f2796bad0c5e5d1304e51331244b671ece60c351
>>>>
>>>> The artifacts to be voted on are located as follows (r18648).
>>>> Source release:
>>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/sources
>>>> Convenience binaries:
>>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/distribution
>>>>
>>>> Release artifacts are signed with a key from the following file:
>>>> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>>>>
>>>> Please vote on releasing this package as Apache Groovy 2.4.10.
>>>>
>>>> The vote is open for the next 72 hours and passes if a majority of at
>>>> least three +1 PMC votes are cast.
>>>>
>>>> [ ] +1 Release Apache Groovy 2.4.10
>>>> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
>>>> [ ] -1 Do not release Apache Groovy 2.4.10 because...
>>>>
>>>> Here is my vote:
>>>>
>>>> +1 (binding)
>>>
>>>
Reply | Threaded
Open this post in threaded view
|

Re: [CANCEL][VOTE] Release Apache Groovy 2.4.10

Guillaume Laforge
Administrator
I upgraded my local Groovy and Gradle to the latest SDKman-available versions (2.4.9 and 3.4.1 respectively).
Re-launching the dist build with --stacktrace, I have something different now...

:groovydocAll FAILED


FAILURE: Build failed with an exception.


* What went wrong:

Execution failed for task ':groovydocAll'.

> java.lang.ExceptionInInitializerError (no error message)


* Try:

Run with --info or --debug option to get more log output.


* Exception is:

org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':groovydocAll'.

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:84)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:55)

        at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:62)

        at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)

        at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:88)

        at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:46)

        at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:51)

        at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)

        at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)

        at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:236)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:228)

        at org.gradle.internal.Transformers$4.transform(Transformers.java:169)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:61)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:228)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:215)

        at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.processTask(AbstractTaskPlanExecutor.java:77)

        at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.run(AbstractTaskPlanExecutor.java:58)

        at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor.process(DefaultTaskPlanExecutor.java:32)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter.execute(DefaultTaskGraphExecuter.java:113)

        at org.gradle.execution.SelectedTaskExecutionAction.execute(SelectedTaskExecutionAction.java:37)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)

        at org.gradle.execution.DefaultBuildExecuter.access$000(DefaultBuildExecuter.java:23)

        at org.gradle.execution.DefaultBuildExecuter$1.proceed(DefaultBuildExecuter.java:43)

        at org.gradle.execution.DryRunBuildExecutionAction.execute(DryRunBuildExecutionAction.java:32)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:30)

        at org.gradle.initialization.DefaultGradleLauncher$RunTasksAction.execute(DefaultGradleLauncher.java:256)

        at org.gradle.initialization.DefaultGradleLauncher$RunTasksAction.execute(DefaultGradleLauncher.java:253)

        at org.gradle.internal.Transformers$4.transform(Transformers.java:169)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:56)

        at org.gradle.initialization.DefaultGradleLauncher.doBuildStages(DefaultGradleLauncher.java:175)

        at org.gradle.initialization.DefaultGradleLauncher.doBuild(DefaultGradleLauncher.java:119)

        at org.gradle.initialization.DefaultGradleLauncher.run(DefaultGradleLauncher.java:102)

        at org.gradle.launcher.exec.GradleBuildController.run(GradleBuildController.java:71)

        at org.gradle.tooling.internal.provider.ExecuteBuildActionRunner.run(ExecuteBuildActionRunner.java:28)

        at org.gradle.launcher.exec.ChainingBuildActionRunner.run(ChainingBuildActionRunner.java:35)

        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:41)

        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:26)

        at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:75)

        at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:49)

        at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:49)

        at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:31)

        at org.gradle.launcher.daemon.server.exec.ExecuteBuild.doBuild(ExecuteBuild.java:67)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.WatchForDisconnection.execute(WatchForDisconnection.java:47)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.ResetDeprecationLogger.execute(ResetDeprecationLogger.java:26)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.RequestStopIfSingleUsedDaemon.execute(RequestStopIfSingleUsedDaemon.java:34)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:74)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:72)

        at org.gradle.util.Swapper.swap(Swapper.java:38)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput.execute(ForwardClientInput.java:72)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.LogAndCheckHealth.execute(LogAndCheckHealth.java:55)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.LogToClient.doBuild(LogToClient.java:60)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.EstablishBuildEnvironment.doBuild(EstablishBuildEnvironment.java:72)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.StartBuildOrRespondWithBusy$1.run(StartBuildOrRespondWithBusy.java:50)

        at org.gradle.launcher.daemon.server.DaemonStateCoordinator$1.run(DaemonStateCoordinator.java:297)

        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)

        at org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:46)

Caused by: java.lang.ExceptionInInitializerError

        at org.gradle.api.internal.classloading.GroovySystemLoaderFactory.forClassLoader(GroovySystemLoaderFactory.java:44)

        at org.gradle.api.internal.project.antbuilder.ClassPathToClassLoaderCache.withCachedClassLoader(ClassPathToClassLoaderCache.java:115)

        at org.gradle.api.internal.project.antbuilder.DefaultIsolatedAntBuilder.execute(DefaultIsolatedAntBuilder.java:127)

        at org.gradle.api.internal.tasks.AntGroovydoc.getGroovyVersion(AntGroovydoc.java:113)

        at org.gradle.api.internal.tasks.AntGroovydoc.execute(AntGroovydoc.java:74)

        at org.gradle.api.tasks.javadoc.Groovydoc.generate(Groovydoc.java:98)

        at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.doExecute(DefaultTaskClassInfoStore.java:141)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:134)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:123)

        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:632)

        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:615)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:95)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:76)

        ... 70 more

Caused by: groovy.lang.GroovyRuntimeException: Unable to load module META-INF descriptor

        ... 84 more

Caused by: java.io.FileNotFoundException: JAR entry META-INF/services/org.codehaus.groovy.runtime.ExtensionModule not found in /Users/glaforge/Downloads/groovy-2.4.10/subprojects/groovy-xml/target/libs/groovy-xml-2.4.10.jar

        ... 84 more



BUILD FAILED


On Tue, Mar 14, 2017 at 6:13 AM, Paul King <[hidden email]> wrote:
Okay, I am going to cancel the vote and try again with the commit
removed for the issue John found. I'll have to work out why one of my
CI builds didn't trigger that error.

I'll start a new vote shortly. Cédric/Guillaume, I'm keen for any
further feedback on why you were having issues with the 'dist' task.
That remains unexplained and unreproducible from my end.

Cheers, Paul.

On Mon, Mar 13, 2017 at 5:16 PM, Paul King <[hidden email]> wrote:
> Hi John,
>
> I did a bit more testing for the non-spock case and perhaps there is
> an issue there. I'll see if Jochen or Cédric have a little more
> knowledge on whether that case should be allowed. Certainly some paths
> give you ClassFormatError with the dot in the name but there seems to
> be other paths which may not depending on how you run it - like the
> test you showed.
>
> Cheers, Paul.
>
> On Mon, Mar 13, 2017 at 10:38 AM, Paul King <[hidden email]> wrote:
>> Hi John, the Spock example is fine since that isn't left as the method
>> name by the time the test is run. I am puzzled how the other one could
>> have ever run.
>>
>> Cheers, Paul.
>>
>> On Sun, Mar 12, 2017 at 9:28 AM, John Wagenleitner
>> <[hidden email]> wrote:
>>> +1
>>>
>>> Just wanted to note that in testing I came across some method names in tests
>>> that had characters that are now no longer allowed in method names [1] [2].
>>> I know this is related to the fix for GROOVY-6792, just thought it was odd
>>> that it seems to have worked in some cases before.
>>>
>>> [1]
>>> https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-test-suite-web/src/test/groovy/org/grails/web/codecs/CodecSpec.groovy#L40
>>>
>>> [2]
>>> https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-core/src/test/groovy/org/grails/compiler/injection/DefaultDomainClassInjectorSpec.groovy#L17
>>>
>>> On Thu, Mar 9, 2017 at 2:29 PM, Paul King <[hidden email]> wrote:
>>>>
>>>> Dear community,
>>>>
>>>> I am happy to start the VOTE thread for a Groovy 2.4.10 release!
>>>>
>>>> This release includes 9 bug fixes/improvements as outlined in the
>>>> changelog:
>>>>
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12339743
>>>>
>>>> Tag:
>>>> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_4_10
>>>> Tag commit id: f2796bad0c5e5d1304e51331244b671ece60c351
>>>>
>>>> The artifacts to be voted on are located as follows (r18648).
>>>> Source release:
>>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/sources
>>>> Convenience binaries:
>>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/distribution
>>>>
>>>> Release artifacts are signed with a key from the following file:
>>>> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>>>>
>>>> Please vote on releasing this package as Apache Groovy 2.4.10.
>>>>
>>>> The vote is open for the next 72 hours and passes if a majority of at
>>>> least three +1 PMC votes are cast.
>>>>
>>>> [ ] +1 Release Apache Groovy 2.4.10
>>>> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
>>>> [ ] -1 Do not release Apache Groovy 2.4.10 because...
>>>>
>>>> Here is my vote:
>>>>
>>>> +1 (binding)
>>>
>>>



--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform

Reply | Threaded
Open this post in threaded view
|

Re: [CANCEL][VOTE] Release Apache Groovy 2.4.10

Cédric Champeau
I think the error comes from using the latest Gradle release with the 2.4.x branch: they don't seem to be compatible. Master uses latest Gradle, not 2.4.x.

2017-03-14 9:01 GMT+01:00 Guillaume Laforge <[hidden email]>:
I upgraded my local Groovy and Gradle to the latest SDKman-available versions (2.4.9 and 3.4.1 respectively).
Re-launching the dist build with --stacktrace, I have something different now...

:groovydocAll FAILED


FAILURE: Build failed with an exception.


* What went wrong:

Execution failed for task ':groovydocAll'.

> java.lang.ExceptionInInitializerError (no error message)


* Try:

Run with --info or --debug option to get more log output.


* Exception is:

org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':groovydocAll'.

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:84)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:55)

        at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:62)

        at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)

        at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:88)

        at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:46)

        at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:51)

        at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)

        at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)

        at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:236)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:228)

        at org.gradle.internal.Transformers$4.transform(Transformers.java:169)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:61)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:228)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:215)

        at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.processTask(AbstractTaskPlanExecutor.java:77)

        at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.run(AbstractTaskPlanExecutor.java:58)

        at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor.process(DefaultTaskPlanExecutor.java:32)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter.execute(DefaultTaskGraphExecuter.java:113)

        at org.gradle.execution.SelectedTaskExecutionAction.execute(SelectedTaskExecutionAction.java:37)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)

        at org.gradle.execution.DefaultBuildExecuter.access$000(DefaultBuildExecuter.java:23)

        at org.gradle.execution.DefaultBuildExecuter$1.proceed(DefaultBuildExecuter.java:43)

        at org.gradle.execution.DryRunBuildExecutionAction.execute(DryRunBuildExecutionAction.java:32)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:30)

        at org.gradle.initialization.DefaultGradleLauncher$RunTasksAction.execute(DefaultGradleLauncher.java:256)

        at org.gradle.initialization.DefaultGradleLauncher$RunTasksAction.execute(DefaultGradleLauncher.java:253)

        at org.gradle.internal.Transformers$4.transform(Transformers.java:169)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:56)

        at org.gradle.initialization.DefaultGradleLauncher.doBuildStages(DefaultGradleLauncher.java:175)

        at org.gradle.initialization.DefaultGradleLauncher.doBuild(DefaultGradleLauncher.java:119)

        at org.gradle.initialization.DefaultGradleLauncher.run(DefaultGradleLauncher.java:102)

        at org.gradle.launcher.exec.GradleBuildController.run(GradleBuildController.java:71)

        at org.gradle.tooling.internal.provider.ExecuteBuildActionRunner.run(ExecuteBuildActionRunner.java:28)

        at org.gradle.launcher.exec.ChainingBuildActionRunner.run(ChainingBuildActionRunner.java:35)

        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:41)

        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:26)

        at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:75)

        at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:49)

        at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:49)

        at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:31)

        at org.gradle.launcher.daemon.server.exec.ExecuteBuild.doBuild(ExecuteBuild.java:67)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.WatchForDisconnection.execute(WatchForDisconnection.java:47)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.ResetDeprecationLogger.execute(ResetDeprecationLogger.java:26)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.RequestStopIfSingleUsedDaemon.execute(RequestStopIfSingleUsedDaemon.java:34)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:74)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:72)

        at org.gradle.util.Swapper.swap(Swapper.java:38)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput.execute(ForwardClientInput.java:72)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.LogAndCheckHealth.execute(LogAndCheckHealth.java:55)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.LogToClient.doBuild(LogToClient.java:60)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.EstablishBuildEnvironment.doBuild(EstablishBuildEnvironment.java:72)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.StartBuildOrRespondWithBusy$1.run(StartBuildOrRespondWithBusy.java:50)

        at org.gradle.launcher.daemon.server.DaemonStateCoordinator$1.run(DaemonStateCoordinator.java:297)

        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)

        at org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:46)

Caused by: java.lang.ExceptionInInitializerError

        at org.gradle.api.internal.classloading.GroovySystemLoaderFactory.forClassLoader(GroovySystemLoaderFactory.java:44)

        at org.gradle.api.internal.project.antbuilder.ClassPathToClassLoaderCache.withCachedClassLoader(ClassPathToClassLoaderCache.java:115)

        at org.gradle.api.internal.project.antbuilder.DefaultIsolatedAntBuilder.execute(DefaultIsolatedAntBuilder.java:127)

        at org.gradle.api.internal.tasks.AntGroovydoc.getGroovyVersion(AntGroovydoc.java:113)

        at org.gradle.api.internal.tasks.AntGroovydoc.execute(AntGroovydoc.java:74)

        at org.gradle.api.tasks.javadoc.Groovydoc.generate(Groovydoc.java:98)

        at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.doExecute(DefaultTaskClassInfoStore.java:141)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:134)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:123)

        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:632)

        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:615)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:95)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:76)

        ... 70 more

Caused by: groovy.lang.GroovyRuntimeException: Unable to load module META-INF descriptor

        ... 84 more

Caused by: java.io.FileNotFoundException: JAR entry META-INF/services/org.codehaus.groovy.runtime.ExtensionModule not found in /Users/glaforge/Downloads/groovy-2.4.10/subprojects/groovy-xml/target/libs/groovy-xml-2.4.10.jar

        ... 84 more



BUILD FAILED


On Tue, Mar 14, 2017 at 6:13 AM, Paul King <[hidden email]> wrote:
Okay, I am going to cancel the vote and try again with the commit
removed for the issue John found. I'll have to work out why one of my
CI builds didn't trigger that error.

I'll start a new vote shortly. Cédric/Guillaume, I'm keen for any
further feedback on why you were having issues with the 'dist' task.
That remains unexplained and unreproducible from my end.

Cheers, Paul.

On Mon, Mar 13, 2017 at 5:16 PM, Paul King <[hidden email]> wrote:
> Hi John,
>
> I did a bit more testing for the non-spock case and perhaps there is
> an issue there. I'll see if Jochen or Cédric have a little more
> knowledge on whether that case should be allowed. Certainly some paths
> give you ClassFormatError with the dot in the name but there seems to
> be other paths which may not depending on how you run it - like the
> test you showed.
>
> Cheers, Paul.
>
> On Mon, Mar 13, 2017 at 10:38 AM, Paul King <[hidden email]> wrote:
>> Hi John, the Spock example is fine since that isn't left as the method
>> name by the time the test is run. I am puzzled how the other one could
>> have ever run.
>>
>> Cheers, Paul.
>>
>> On Sun, Mar 12, 2017 at 9:28 AM, John Wagenleitner
>> <[hidden email]> wrote:
>>> +1
>>>
>>> Just wanted to note that in testing I came across some method names in tests
>>> that had characters that are now no longer allowed in method names [1] [2].
>>> I know this is related to the fix for GROOVY-6792, just thought it was odd
>>> that it seems to have worked in some cases before.
>>>
>>> [1]
>>> https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-test-suite-web/src/test/groovy/org/grails/web/codecs/CodecSpec.groovy#L40
>>>
>>> [2]
>>> https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-core/src/test/groovy/org/grails/compiler/injection/DefaultDomainClassInjectorSpec.groovy#L17
>>>
>>> On Thu, Mar 9, 2017 at 2:29 PM, Paul King <[hidden email]> wrote:
>>>>
>>>> Dear community,
>>>>
>>>> I am happy to start the VOTE thread for a Groovy 2.4.10 release!
>>>>
>>>> This release includes 9 bug fixes/improvements as outlined in the
>>>> changelog:
>>>>
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12339743
>>>>
>>>> Tag:
>>>> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_4_10
>>>> Tag commit id: f2796bad0c5e5d1304e51331244b671ece60c351
>>>>
>>>> The artifacts to be voted on are located as follows (r18648).
>>>> Source release:
>>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/sources
>>>> Convenience binaries:
>>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/distribution
>>>>
>>>> Release artifacts are signed with a key from the following file:
>>>> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>>>>
>>>> Please vote on releasing this package as Apache Groovy 2.4.10.
>>>>
>>>> The vote is open for the next 72 hours and passes if a majority of at
>>>> least three +1 PMC votes are cast.
>>>>
>>>> [ ] +1 Release Apache Groovy 2.4.10
>>>> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
>>>> [ ] -1 Do not release Apache Groovy 2.4.10 because...
>>>>
>>>> Here is my vote:
>>>>
>>>> +1 (binding)
>>>
>>>



--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform


Reply | Threaded
Open this post in threaded view
|

Re: [CANCEL][VOTE] Release Apache Groovy 2.4.10

Cédric Champeau
Actually got the same error as Guillaume using Gradle 2.3: https://gradle.com/s/5d6oqw3wsbtny

There's something wrong with the build somehow. I guess this one happens when the build isn't clean. It definitely needs a rewrite to benefit from all the latest Gradle nifties.


2017-03-14 10:53 GMT+01:00 Cédric Champeau <[hidden email]>:
I think the error comes from using the latest Gradle release with the 2.4.x branch: they don't seem to be compatible. Master uses latest Gradle, not 2.4.x.

2017-03-14 9:01 GMT+01:00 Guillaume Laforge <[hidden email]>:
I upgraded my local Groovy and Gradle to the latest SDKman-available versions (2.4.9 and 3.4.1 respectively).
Re-launching the dist build with --stacktrace, I have something different now...

:groovydocAll FAILED


FAILURE: Build failed with an exception.


* What went wrong:

Execution failed for task ':groovydocAll'.

> java.lang.ExceptionInInitializerError (no error message)


* Try:

Run with --info or --debug option to get more log output.


* Exception is:

org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':groovydocAll'.

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:84)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:55)

        at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:62)

        at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)

        at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:88)

        at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:46)

        at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:51)

        at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)

        at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)

        at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:236)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:228)

        at org.gradle.internal.Transformers$4.transform(Transformers.java:169)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:61)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:228)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:215)

        at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.processTask(AbstractTaskPlanExecutor.java:77)

        at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.run(AbstractTaskPlanExecutor.java:58)

        at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor.process(DefaultTaskPlanExecutor.java:32)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter.execute(DefaultTaskGraphExecuter.java:113)

        at org.gradle.execution.SelectedTaskExecutionAction.execute(SelectedTaskExecutionAction.java:37)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)

        at org.gradle.execution.DefaultBuildExecuter.access$000(DefaultBuildExecuter.java:23)

        at org.gradle.execution.DefaultBuildExecuter$1.proceed(DefaultBuildExecuter.java:43)

        at org.gradle.execution.DryRunBuildExecutionAction.execute(DryRunBuildExecutionAction.java:32)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:30)

        at org.gradle.initialization.DefaultGradleLauncher$RunTasksAction.execute(DefaultGradleLauncher.java:256)

        at org.gradle.initialization.DefaultGradleLauncher$RunTasksAction.execute(DefaultGradleLauncher.java:253)

        at org.gradle.internal.Transformers$4.transform(Transformers.java:169)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:56)

        at org.gradle.initialization.DefaultGradleLauncher.doBuildStages(DefaultGradleLauncher.java:175)

        at org.gradle.initialization.DefaultGradleLauncher.doBuild(DefaultGradleLauncher.java:119)

        at org.gradle.initialization.DefaultGradleLauncher.run(DefaultGradleLauncher.java:102)

        at org.gradle.launcher.exec.GradleBuildController.run(GradleBuildController.java:71)

        at org.gradle.tooling.internal.provider.ExecuteBuildActionRunner.run(ExecuteBuildActionRunner.java:28)

        at org.gradle.launcher.exec.ChainingBuildActionRunner.run(ChainingBuildActionRunner.java:35)

        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:41)

        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:26)

        at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:75)

        at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:49)

        at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:49)

        at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:31)

        at org.gradle.launcher.daemon.server.exec.ExecuteBuild.doBuild(ExecuteBuild.java:67)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.WatchForDisconnection.execute(WatchForDisconnection.java:47)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.ResetDeprecationLogger.execute(ResetDeprecationLogger.java:26)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.RequestStopIfSingleUsedDaemon.execute(RequestStopIfSingleUsedDaemon.java:34)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:74)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:72)

        at org.gradle.util.Swapper.swap(Swapper.java:38)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput.execute(ForwardClientInput.java:72)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.LogAndCheckHealth.execute(LogAndCheckHealth.java:55)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.LogToClient.doBuild(LogToClient.java:60)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.EstablishBuildEnvironment.doBuild(EstablishBuildEnvironment.java:72)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.StartBuildOrRespondWithBusy$1.run(StartBuildOrRespondWithBusy.java:50)

        at org.gradle.launcher.daemon.server.DaemonStateCoordinator$1.run(DaemonStateCoordinator.java:297)

        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)

        at org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:46)

Caused by: java.lang.ExceptionInInitializerError

        at org.gradle.api.internal.classloading.GroovySystemLoaderFactory.forClassLoader(GroovySystemLoaderFactory.java:44)

        at org.gradle.api.internal.project.antbuilder.ClassPathToClassLoaderCache.withCachedClassLoader(ClassPathToClassLoaderCache.java:115)

        at org.gradle.api.internal.project.antbuilder.DefaultIsolatedAntBuilder.execute(DefaultIsolatedAntBuilder.java:127)

        at org.gradle.api.internal.tasks.AntGroovydoc.getGroovyVersion(AntGroovydoc.java:113)

        at org.gradle.api.internal.tasks.AntGroovydoc.execute(AntGroovydoc.java:74)

        at org.gradle.api.tasks.javadoc.Groovydoc.generate(Groovydoc.java:98)

        at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.doExecute(DefaultTaskClassInfoStore.java:141)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:134)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:123)

        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:632)

        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:615)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:95)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:76)

        ... 70 more

Caused by: groovy.lang.GroovyRuntimeException: Unable to load module META-INF descriptor

        ... 84 more

Caused by: java.io.FileNotFoundException: JAR entry META-INF/services/org.codehaus.groovy.runtime.ExtensionModule not found in /Users/glaforge/Downloads/groovy-2.4.10/subprojects/groovy-xml/target/libs/groovy-xml-2.4.10.jar

        ... 84 more



BUILD FAILED


On Tue, Mar 14, 2017 at 6:13 AM, Paul King <[hidden email]> wrote:
Okay, I am going to cancel the vote and try again with the commit
removed for the issue John found. I'll have to work out why one of my
CI builds didn't trigger that error.

I'll start a new vote shortly. Cédric/Guillaume, I'm keen for any
further feedback on why you were having issues with the 'dist' task.
That remains unexplained and unreproducible from my end.

Cheers, Paul.

On Mon, Mar 13, 2017 at 5:16 PM, Paul King <[hidden email]> wrote:
> Hi John,
>
> I did a bit more testing for the non-spock case and perhaps there is
> an issue there. I'll see if Jochen or Cédric have a little more
> knowledge on whether that case should be allowed. Certainly some paths
> give you ClassFormatError with the dot in the name but there seems to
> be other paths which may not depending on how you run it - like the
> test you showed.
>
> Cheers, Paul.
>
> On Mon, Mar 13, 2017 at 10:38 AM, Paul King <[hidden email]> wrote:
>> Hi John, the Spock example is fine since that isn't left as the method
>> name by the time the test is run. I am puzzled how the other one could
>> have ever run.
>>
>> Cheers, Paul.
>>
>> On Sun, Mar 12, 2017 at 9:28 AM, John Wagenleitner
>> <[hidden email]> wrote:
>>> +1
>>>
>>> Just wanted to note that in testing I came across some method names in tests
>>> that had characters that are now no longer allowed in method names [1] [2].
>>> I know this is related to the fix for GROOVY-6792, just thought it was odd
>>> that it seems to have worked in some cases before.
>>>
>>> [1]
>>> https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-test-suite-web/src/test/groovy/org/grails/web/codecs/CodecSpec.groovy#L40
>>>
>>> [2]
>>> https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-core/src/test/groovy/org/grails/compiler/injection/DefaultDomainClassInjectorSpec.groovy#L17
>>>
>>> On Thu, Mar 9, 2017 at 2:29 PM, Paul King <[hidden email]> wrote:
>>>>
>>>> Dear community,
>>>>
>>>> I am happy to start the VOTE thread for a Groovy 2.4.10 release!
>>>>
>>>> This release includes 9 bug fixes/improvements as outlined in the
>>>> changelog:
>>>>
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12339743
>>>>
>>>> Tag:
>>>> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_4_10
>>>> Tag commit id: f2796bad0c5e5d1304e51331244b671ece60c351
>>>>
>>>> The artifacts to be voted on are located as follows (r18648).
>>>> Source release:
>>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/sources
>>>> Convenience binaries:
>>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/distribution
>>>>
>>>> Release artifacts are signed with a key from the following file:
>>>> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>>>>
>>>> Please vote on releasing this package as Apache Groovy 2.4.10.
>>>>
>>>> The vote is open for the next 72 hours and passes if a majority of at
>>>> least three +1 PMC votes are cast.
>>>>
>>>> [ ] +1 Release Apache Groovy 2.4.10
>>>> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
>>>> [ ] -1 Do not release Apache Groovy 2.4.10 because...
>>>>
>>>> Here is my vote:
>>>>
>>>> +1 (binding)
>>>
>>>



--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform



Reply | Threaded
Open this post in threaded view
|

Re: [CANCEL][VOTE] Release Apache Groovy 2.4.10

Guillaume Laforge
Administrator
There's indeed a problem with cleanliness.
I get Antlr related problems in AntlrParserPlugin when not cleaning.

I'm gonna try with the wrapper, just in case, as suggested by Paul.

On Tue, Mar 14, 2017 at 11:12 AM, Cédric Champeau <[hidden email]> wrote:
Actually got the same error as Guillaume using Gradle 2.3: https://gradle.com/s/5d6oqw3wsbtny

There's something wrong with the build somehow. I guess this one happens when the build isn't clean. It definitely needs a rewrite to benefit from all the latest Gradle nifties.


2017-03-14 10:53 GMT+01:00 Cédric Champeau <[hidden email]>:
I think the error comes from using the latest Gradle release with the 2.4.x branch: they don't seem to be compatible. Master uses latest Gradle, not 2.4.x.

2017-03-14 9:01 GMT+01:00 Guillaume Laforge <[hidden email]>:
I upgraded my local Groovy and Gradle to the latest SDKman-available versions (2.4.9 and 3.4.1 respectively).
Re-launching the dist build with --stacktrace, I have something different now...

:groovydocAll FAILED


FAILURE: Build failed with an exception.


* What went wrong:

Execution failed for task ':groovydocAll'.

> java.lang.ExceptionInInitializerError (no error message)


* Try:

Run with --info or --debug option to get more log output.


* Exception is:

org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':groovydocAll'.

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:84)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:55)

        at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:62)

        at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)

        at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:88)

        at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:46)

        at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:51)

        at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)

        at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)

        at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:236)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:228)

        at org.gradle.internal.Transformers$4.transform(Transformers.java:169)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:61)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:228)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:215)

        at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.processTask(AbstractTaskPlanExecutor.java:77)

        at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.run(AbstractTaskPlanExecutor.java:58)

        at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor.process(DefaultTaskPlanExecutor.java:32)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter.execute(DefaultTaskGraphExecuter.java:113)

        at org.gradle.execution.SelectedTaskExecutionAction.execute(SelectedTaskExecutionAction.java:37)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)

        at org.gradle.execution.DefaultBuildExecuter.access$000(DefaultBuildExecuter.java:23)

        at org.gradle.execution.DefaultBuildExecuter$1.proceed(DefaultBuildExecuter.java:43)

        at org.gradle.execution.DryRunBuildExecutionAction.execute(DryRunBuildExecutionAction.java:32)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:30)

        at org.gradle.initialization.DefaultGradleLauncher$RunTasksAction.execute(DefaultGradleLauncher.java:256)

        at org.gradle.initialization.DefaultGradleLauncher$RunTasksAction.execute(DefaultGradleLauncher.java:253)

        at org.gradle.internal.Transformers$4.transform(Transformers.java:169)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:56)

        at org.gradle.initialization.DefaultGradleLauncher.doBuildStages(DefaultGradleLauncher.java:175)

        at org.gradle.initialization.DefaultGradleLauncher.doBuild(DefaultGradleLauncher.java:119)

        at org.gradle.initialization.DefaultGradleLauncher.run(DefaultGradleLauncher.java:102)

        at org.gradle.launcher.exec.GradleBuildController.run(GradleBuildController.java:71)

        at org.gradle.tooling.internal.provider.ExecuteBuildActionRunner.run(ExecuteBuildActionRunner.java:28)

        at org.gradle.launcher.exec.ChainingBuildActionRunner.run(ChainingBuildActionRunner.java:35)

        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:41)

        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:26)

        at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:75)

        at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:49)

        at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:49)

        at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:31)

        at org.gradle.launcher.daemon.server.exec.ExecuteBuild.doBuild(ExecuteBuild.java:67)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.WatchForDisconnection.execute(WatchForDisconnection.java:47)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.ResetDeprecationLogger.execute(ResetDeprecationLogger.java:26)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.RequestStopIfSingleUsedDaemon.execute(RequestStopIfSingleUsedDaemon.java:34)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:74)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:72)

        at org.gradle.util.Swapper.swap(Swapper.java:38)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput.execute(ForwardClientInput.java:72)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.LogAndCheckHealth.execute(LogAndCheckHealth.java:55)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.LogToClient.doBuild(LogToClient.java:60)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.EstablishBuildEnvironment.doBuild(EstablishBuildEnvironment.java:72)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.StartBuildOrRespondWithBusy$1.run(StartBuildOrRespondWithBusy.java:50)

        at org.gradle.launcher.daemon.server.DaemonStateCoordinator$1.run(DaemonStateCoordinator.java:297)

        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)

        at org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:46)

Caused by: java.lang.ExceptionInInitializerError

        at org.gradle.api.internal.classloading.GroovySystemLoaderFactory.forClassLoader(GroovySystemLoaderFactory.java:44)

        at org.gradle.api.internal.project.antbuilder.ClassPathToClassLoaderCache.withCachedClassLoader(ClassPathToClassLoaderCache.java:115)

        at org.gradle.api.internal.project.antbuilder.DefaultIsolatedAntBuilder.execute(DefaultIsolatedAntBuilder.java:127)

        at org.gradle.api.internal.tasks.AntGroovydoc.getGroovyVersion(AntGroovydoc.java:113)

        at org.gradle.api.internal.tasks.AntGroovydoc.execute(AntGroovydoc.java:74)

        at org.gradle.api.tasks.javadoc.Groovydoc.generate(Groovydoc.java:98)

        at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.doExecute(DefaultTaskClassInfoStore.java:141)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:134)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:123)

        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:632)

        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:615)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:95)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:76)

        ... 70 more

Caused by: groovy.lang.GroovyRuntimeException: Unable to load module META-INF descriptor

        ... 84 more

Caused by: java.io.FileNotFoundException: JAR entry META-INF/services/org.codehaus.groovy.runtime.ExtensionModule not found in /Users/glaforge/Downloads/groovy-2.4.10/subprojects/groovy-xml/target/libs/groovy-xml-2.4.10.jar

        ... 84 more



BUILD FAILED


On Tue, Mar 14, 2017 at 6:13 AM, Paul King <[hidden email]> wrote:
Okay, I am going to cancel the vote and try again with the commit
removed for the issue John found. I'll have to work out why one of my
CI builds didn't trigger that error.

I'll start a new vote shortly. Cédric/Guillaume, I'm keen for any
further feedback on why you were having issues with the 'dist' task.
That remains unexplained and unreproducible from my end.

Cheers, Paul.

On Mon, Mar 13, 2017 at 5:16 PM, Paul King <[hidden email]> wrote:
> Hi John,
>
> I did a bit more testing for the non-spock case and perhaps there is
> an issue there. I'll see if Jochen or Cédric have a little more
> knowledge on whether that case should be allowed. Certainly some paths
> give you ClassFormatError with the dot in the name but there seems to
> be other paths which may not depending on how you run it - like the
> test you showed.
>
> Cheers, Paul.
>
> On Mon, Mar 13, 2017 at 10:38 AM, Paul King <[hidden email]> wrote:
>> Hi John, the Spock example is fine since that isn't left as the method
>> name by the time the test is run. I am puzzled how the other one could
>> have ever run.
>>
>> Cheers, Paul.
>>
>> On Sun, Mar 12, 2017 at 9:28 AM, John Wagenleitner
>> <[hidden email]> wrote:
>>> +1
>>>
>>> Just wanted to note that in testing I came across some method names in tests
>>> that had characters that are now no longer allowed in method names [1] [2].
>>> I know this is related to the fix for GROOVY-6792, just thought it was odd
>>> that it seems to have worked in some cases before.
>>>
>>> [1]
>>> https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-test-suite-web/src/test/groovy/org/grails/web/codecs/CodecSpec.groovy#L40
>>>
>>> [2]
>>> https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-core/src/test/groovy/org/grails/compiler/injection/DefaultDomainClassInjectorSpec.groovy#L17
>>>
>>> On Thu, Mar 9, 2017 at 2:29 PM, Paul King <[hidden email]> wrote:
>>>>
>>>> Dear community,
>>>>
>>>> I am happy to start the VOTE thread for a Groovy 2.4.10 release!
>>>>
>>>> This release includes 9 bug fixes/improvements as outlined in the
>>>> changelog:
>>>>
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12339743
>>>>
>>>> Tag:
>>>> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_4_10
>>>> Tag commit id: f2796bad0c5e5d1304e51331244b671ece60c351
>>>>
>>>> The artifacts to be voted on are located as follows (r18648).
>>>> Source release:
>>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/sources
>>>> Convenience binaries:
>>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/distribution
>>>>
>>>> Release artifacts are signed with a key from the following file:
>>>> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>>>>
>>>> Please vote on releasing this package as Apache Groovy 2.4.10.
>>>>
>>>> The vote is open for the next 72 hours and passes if a majority of at
>>>> least three +1 PMC votes are cast.
>>>>
>>>> [ ] +1 Release Apache Groovy 2.4.10
>>>> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
>>>> [ ] -1 Do not release Apache Groovy 2.4.10 because...
>>>>
>>>> Here is my vote:
>>>>
>>>> +1 (binding)
>>>
>>>



--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform






--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform

Reply | Threaded
Open this post in threaded view
|

Re: [CANCEL][VOTE] Release Apache Groovy 2.4.10

Guillaume Laforge
Administrator
And with gradlew, in spite of a clean, doing dist gives me tons of those AntlrParserPlugin errors :-O

:compileJava

warning: [options] bootstrap class path not set in conjunction with -source 1.6

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/ast/tools/GenericsUtils.java:26: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyLexer;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/ast/tools/GenericsUtils.java:27: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyRecognizer;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/AntlrParserPlugin.java:26: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyLexer;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/AntlrParserPlugin.java:27: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyRecognizer;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/AntlrParserPlugin.java:28: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyTokenTypes;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/AntlrParserPlugin.java:58: error: cannot find symbol

public class AntlrParserPlugin extends ASTHelper implements ParserPlugin, GroovyTokenTypes {

                                                                          ^

  symbol: class GroovyTokenTypes

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/java/Groovifier.java:22: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyTokenTypes;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/java/Groovifier.java:25: error: cannot find symbol

public class Groovifier extends VisitorAdapter implements GroovyTokenTypes {

                                                          ^

  symbol: class GroovyTokenTypes

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/java/Java2GroovyConverter.java:22: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyTokenTypes;

                                       ^


On Tue, Mar 14, 2017 at 12:21 PM, Guillaume Laforge <[hidden email]> wrote:
There's indeed a problem with cleanliness.
I get Antlr related problems in AntlrParserPlugin when not cleaning.

I'm gonna try with the wrapper, just in case, as suggested by Paul.

On Tue, Mar 14, 2017 at 11:12 AM, Cédric Champeau <[hidden email]> wrote:
Actually got the same error as Guillaume using Gradle 2.3: https://gradle.com/s/5d6oqw3wsbtny

There's something wrong with the build somehow. I guess this one happens when the build isn't clean. It definitely needs a rewrite to benefit from all the latest Gradle nifties.


2017-03-14 10:53 GMT+01:00 Cédric Champeau <[hidden email]>:
I think the error comes from using the latest Gradle release with the 2.4.x branch: they don't seem to be compatible. Master uses latest Gradle, not 2.4.x.

2017-03-14 9:01 GMT+01:00 Guillaume Laforge <[hidden email]>:
I upgraded my local Groovy and Gradle to the latest SDKman-available versions (2.4.9 and 3.4.1 respectively).
Re-launching the dist build with --stacktrace, I have something different now...

:groovydocAll FAILED


FAILURE: Build failed with an exception.


* What went wrong:

Execution failed for task ':groovydocAll'.

> java.lang.ExceptionInInitializerError (no error message)


* Try:

Run with --info or --debug option to get more log output.


* Exception is:

org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':groovydocAll'.

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:84)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:55)

        at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:62)

        at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)

        at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:88)

        at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:46)

        at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:51)

        at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)

        at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)

        at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:236)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:228)

        at org.gradle.internal.Transformers$4.transform(Transformers.java:169)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:61)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:228)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:215)

        at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.processTask(AbstractTaskPlanExecutor.java:77)

        at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.run(AbstractTaskPlanExecutor.java:58)

        at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor.process(DefaultTaskPlanExecutor.java:32)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter.execute(DefaultTaskGraphExecuter.java:113)

        at org.gradle.execution.SelectedTaskExecutionAction.execute(SelectedTaskExecutionAction.java:37)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)

        at org.gradle.execution.DefaultBuildExecuter.access$000(DefaultBuildExecuter.java:23)

        at org.gradle.execution.DefaultBuildExecuter$1.proceed(DefaultBuildExecuter.java:43)

        at org.gradle.execution.DryRunBuildExecutionAction.execute(DryRunBuildExecutionAction.java:32)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:30)

        at org.gradle.initialization.DefaultGradleLauncher$RunTasksAction.execute(DefaultGradleLauncher.java:256)

        at org.gradle.initialization.DefaultGradleLauncher$RunTasksAction.execute(DefaultGradleLauncher.java:253)

        at org.gradle.internal.Transformers$4.transform(Transformers.java:169)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:56)

        at org.gradle.initialization.DefaultGradleLauncher.doBuildStages(DefaultGradleLauncher.java:175)

        at org.gradle.initialization.DefaultGradleLauncher.doBuild(DefaultGradleLauncher.java:119)

        at org.gradle.initialization.DefaultGradleLauncher.run(DefaultGradleLauncher.java:102)

        at org.gradle.launcher.exec.GradleBuildController.run(GradleBuildController.java:71)

        at org.gradle.tooling.internal.provider.ExecuteBuildActionRunner.run(ExecuteBuildActionRunner.java:28)

        at org.gradle.launcher.exec.ChainingBuildActionRunner.run(ChainingBuildActionRunner.java:35)

        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:41)

        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:26)

        at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:75)

        at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:49)

        at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:49)

        at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:31)

        at org.gradle.launcher.daemon.server.exec.ExecuteBuild.doBuild(ExecuteBuild.java:67)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.WatchForDisconnection.execute(WatchForDisconnection.java:47)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.ResetDeprecationLogger.execute(ResetDeprecationLogger.java:26)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.RequestStopIfSingleUsedDaemon.execute(RequestStopIfSingleUsedDaemon.java:34)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:74)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:72)

        at org.gradle.util.Swapper.swap(Swapper.java:38)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput.execute(ForwardClientInput.java:72)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.LogAndCheckHealth.execute(LogAndCheckHealth.java:55)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.LogToClient.doBuild(LogToClient.java:60)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.EstablishBuildEnvironment.doBuild(EstablishBuildEnvironment.java:72)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.StartBuildOrRespondWithBusy$1.run(StartBuildOrRespondWithBusy.java:50)

        at org.gradle.launcher.daemon.server.DaemonStateCoordinator$1.run(DaemonStateCoordinator.java:297)

        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)

        at org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:46)

Caused by: java.lang.ExceptionInInitializerError

        at org.gradle.api.internal.classloading.GroovySystemLoaderFactory.forClassLoader(GroovySystemLoaderFactory.java:44)

        at org.gradle.api.internal.project.antbuilder.ClassPathToClassLoaderCache.withCachedClassLoader(ClassPathToClassLoaderCache.java:115)

        at org.gradle.api.internal.project.antbuilder.DefaultIsolatedAntBuilder.execute(DefaultIsolatedAntBuilder.java:127)

        at org.gradle.api.internal.tasks.AntGroovydoc.getGroovyVersion(AntGroovydoc.java:113)

        at org.gradle.api.internal.tasks.AntGroovydoc.execute(AntGroovydoc.java:74)

        at org.gradle.api.tasks.javadoc.Groovydoc.generate(Groovydoc.java:98)

        at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.doExecute(DefaultTaskClassInfoStore.java:141)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:134)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:123)

        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:632)

        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:615)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:95)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:76)

        ... 70 more

Caused by: groovy.lang.GroovyRuntimeException: Unable to load module META-INF descriptor

        ... 84 more

Caused by: java.io.FileNotFoundException: JAR entry META-INF/services/org.codehaus.groovy.runtime.ExtensionModule not found in /Users/glaforge/Downloads/groovy-2.4.10/subprojects/groovy-xml/target/libs/groovy-xml-2.4.10.jar

        ... 84 more



BUILD FAILED


On Tue, Mar 14, 2017 at 6:13 AM, Paul King <[hidden email]> wrote:
Okay, I am going to cancel the vote and try again with the commit
removed for the issue John found. I'll have to work out why one of my
CI builds didn't trigger that error.

I'll start a new vote shortly. Cédric/Guillaume, I'm keen for any
further feedback on why you were having issues with the 'dist' task.
That remains unexplained and unreproducible from my end.

Cheers, Paul.

On Mon, Mar 13, 2017 at 5:16 PM, Paul King <[hidden email]> wrote:
> Hi John,
>
> I did a bit more testing for the non-spock case and perhaps there is
> an issue there. I'll see if Jochen or Cédric have a little more
> knowledge on whether that case should be allowed. Certainly some paths
> give you ClassFormatError with the dot in the name but there seems to
> be other paths which may not depending on how you run it - like the
> test you showed.
>
> Cheers, Paul.
>
> On Mon, Mar 13, 2017 at 10:38 AM, Paul King <[hidden email]> wrote:
>> Hi John, the Spock example is fine since that isn't left as the method
>> name by the time the test is run. I am puzzled how the other one could
>> have ever run.
>>
>> Cheers, Paul.
>>
>> On Sun, Mar 12, 2017 at 9:28 AM, John Wagenleitner
>> <[hidden email]> wrote:
>>> +1
>>>
>>> Just wanted to note that in testing I came across some method names in tests
>>> that had characters that are now no longer allowed in method names [1] [2].
>>> I know this is related to the fix for GROOVY-6792, just thought it was odd
>>> that it seems to have worked in some cases before.
>>>
>>> [1]
>>> https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-test-suite-web/src/test/groovy/org/grails/web/codecs/CodecSpec.groovy#L40
>>>
>>> [2]
>>> https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-core/src/test/groovy/org/grails/compiler/injection/DefaultDomainClassInjectorSpec.groovy#L17
>>>
>>> On Thu, Mar 9, 2017 at 2:29 PM, Paul King <[hidden email]> wrote:
>>>>
>>>> Dear community,
>>>>
>>>> I am happy to start the VOTE thread for a Groovy 2.4.10 release!
>>>>
>>>> This release includes 9 bug fixes/improvements as outlined in the
>>>> changelog:
>>>>
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12339743
>>>>
>>>> Tag:
>>>> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_4_10
>>>> Tag commit id: f2796bad0c5e5d1304e51331244b671ece60c351
>>>>
>>>> The artifacts to be voted on are located as follows (r18648).
>>>> Source release:
>>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/sources
>>>> Convenience binaries:
>>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/distribution
>>>>
>>>> Release artifacts are signed with a key from the following file:
>>>> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>>>>
>>>> Please vote on releasing this package as Apache Groovy 2.4.10.
>>>>
>>>> The vote is open for the next 72 hours and passes if a majority of at
>>>> least three +1 PMC votes are cast.
>>>>
>>>> [ ] +1 Release Apache Groovy 2.4.10
>>>> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
>>>> [ ] -1 Do not release Apache Groovy 2.4.10 because...
>>>>
>>>> Here is my vote:
>>>>
>>>> +1 (binding)
>>>
>>>



--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform






--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform




--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform

Reply | Threaded
Open this post in threaded view
|

Re: [CANCEL][VOTE] Release Apache Groovy 2.4.10

Guillaume Laforge
Administrator
Rebuilding from a fresh source zip, using gradlew, I still get the error:

* What went wrong:

Execution failed for task ':groovydocAll'.

> java.lang.VerifyError: Bad type on operand stack

  Exception Details:

    Location:

      org/codehaus/groovy/tools/groovydoc/GroovyRootDocBuilder.getJavaParser(Ljava/lang/String;Lorg/codehaus/groovy/antlr/SourceBuffer;)Lorg/codehaus/groovy/antlr/java/JavaRecognizer; @28: invokevirtual

    Reason:

      Type 'org/codehaus/groovy/antlr/java/JavaLexer' (current frame, stack[1]) is not assignable to 'groovyjarjarantlr/CharScanner'

    Current Frame:

      bci: @28

      flags: { }

      locals: { 'java/lang/String', 'org/codehaus/groovy/antlr/SourceBuffer', 'org/codehaus/groovy/antlr/UnicodeEscapingReader', 'org/codehaus/groovy/antlr/java/JavaLexer' }

      stack: { 'org/codehaus/groovy/antlr/UnicodeEscapingReader', 'org/codehaus/groovy/antlr/java/JavaLexer' }

    Bytecode:

      0x0000000: bb00 bb59 bb00 bd59 2ab7 00be 2bb7 00c1

      0x0000010: 4dbb 00c3 592c b700 c64e 2c2d b600 ca2d

      0x0000020: b800 ce3a 0419 042b b600 d219 04b0  


On Tue, Mar 14, 2017 at 12:23 PM, Guillaume Laforge <[hidden email]> wrote:
And with gradlew, in spite of a clean, doing dist gives me tons of those AntlrParserPlugin errors :-O

:compileJava

warning: [options] bootstrap class path not set in conjunction with -source 1.6

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/ast/tools/GenericsUtils.java:26: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyLexer;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/ast/tools/GenericsUtils.java:27: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyRecognizer;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/AntlrParserPlugin.java:26: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyLexer;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/AntlrParserPlugin.java:27: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyRecognizer;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/AntlrParserPlugin.java:28: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyTokenTypes;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/AntlrParserPlugin.java:58: error: cannot find symbol

public class AntlrParserPlugin extends ASTHelper implements ParserPlugin, GroovyTokenTypes {

                                                                          ^

  symbol: class GroovyTokenTypes

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/java/Groovifier.java:22: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyTokenTypes;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/java/Groovifier.java:25: error: cannot find symbol

public class Groovifier extends VisitorAdapter implements GroovyTokenTypes {

                                                          ^

  symbol: class GroovyTokenTypes

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/java/Java2GroovyConverter.java:22: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyTokenTypes;

                                       ^


On Tue, Mar 14, 2017 at 12:21 PM, Guillaume Laforge <[hidden email]> wrote:
There's indeed a problem with cleanliness.
I get Antlr related problems in AntlrParserPlugin when not cleaning.

I'm gonna try with the wrapper, just in case, as suggested by Paul.

On Tue, Mar 14, 2017 at 11:12 AM, Cédric Champeau <[hidden email]> wrote:
Actually got the same error as Guillaume using Gradle 2.3: https://gradle.com/s/5d6oqw3wsbtny

There's something wrong with the build somehow. I guess this one happens when the build isn't clean. It definitely needs a rewrite to benefit from all the latest Gradle nifties.


2017-03-14 10:53 GMT+01:00 Cédric Champeau <[hidden email]>:
I think the error comes from using the latest Gradle release with the 2.4.x branch: they don't seem to be compatible. Master uses latest Gradle, not 2.4.x.

2017-03-14 9:01 GMT+01:00 Guillaume Laforge <[hidden email]>:
I upgraded my local Groovy and Gradle to the latest SDKman-available versions (2.4.9 and 3.4.1 respectively).
Re-launching the dist build with --stacktrace, I have something different now...

:groovydocAll FAILED


FAILURE: Build failed with an exception.


* What went wrong:

Execution failed for task ':groovydocAll'.

> java.lang.ExceptionInInitializerError (no error message)


* Try:

Run with --info or --debug option to get more log output.


* Exception is:

org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':groovydocAll'.

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:84)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:55)

        at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:62)

        at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)

        at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:88)

        at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:46)

        at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:51)

        at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)

        at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)

        at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:236)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:228)

        at org.gradle.internal.Transformers$4.transform(Transformers.java:169)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:61)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:228)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:215)

        at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.processTask(AbstractTaskPlanExecutor.java:77)

        at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.run(AbstractTaskPlanExecutor.java:58)

        at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor.process(DefaultTaskPlanExecutor.java:32)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter.execute(DefaultTaskGraphExecuter.java:113)

        at org.gradle.execution.SelectedTaskExecutionAction.execute(SelectedTaskExecutionAction.java:37)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)

        at org.gradle.execution.DefaultBuildExecuter.access$000(DefaultBuildExecuter.java:23)

        at org.gradle.execution.DefaultBuildExecuter$1.proceed(DefaultBuildExecuter.java:43)

        at org.gradle.execution.DryRunBuildExecutionAction.execute(DryRunBuildExecutionAction.java:32)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:30)

        at org.gradle.initialization.DefaultGradleLauncher$RunTasksAction.execute(DefaultGradleLauncher.java:256)

        at org.gradle.initialization.DefaultGradleLauncher$RunTasksAction.execute(DefaultGradleLauncher.java:253)

        at org.gradle.internal.Transformers$4.transform(Transformers.java:169)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:56)

        at org.gradle.initialization.DefaultGradleLauncher.doBuildStages(DefaultGradleLauncher.java:175)

        at org.gradle.initialization.DefaultGradleLauncher.doBuild(DefaultGradleLauncher.java:119)

        at org.gradle.initialization.DefaultGradleLauncher.run(DefaultGradleLauncher.java:102)

        at org.gradle.launcher.exec.GradleBuildController.run(GradleBuildController.java:71)

        at org.gradle.tooling.internal.provider.ExecuteBuildActionRunner.run(ExecuteBuildActionRunner.java:28)

        at org.gradle.launcher.exec.ChainingBuildActionRunner.run(ChainingBuildActionRunner.java:35)

        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:41)

        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:26)

        at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:75)

        at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:49)

        at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:49)

        at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:31)

        at org.gradle.launcher.daemon.server.exec.ExecuteBuild.doBuild(ExecuteBuild.java:67)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.WatchForDisconnection.execute(WatchForDisconnection.java:47)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.ResetDeprecationLogger.execute(ResetDeprecationLogger.java:26)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.RequestStopIfSingleUsedDaemon.execute(RequestStopIfSingleUsedDaemon.java:34)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:74)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:72)

        at org.gradle.util.Swapper.swap(Swapper.java:38)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput.execute(ForwardClientInput.java:72)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.LogAndCheckHealth.execute(LogAndCheckHealth.java:55)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.LogToClient.doBuild(LogToClient.java:60)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.EstablishBuildEnvironment.doBuild(EstablishBuildEnvironment.java:72)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.StartBuildOrRespondWithBusy$1.run(StartBuildOrRespondWithBusy.java:50)

        at org.gradle.launcher.daemon.server.DaemonStateCoordinator$1.run(DaemonStateCoordinator.java:297)

        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)

        at org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:46)

Caused by: java.lang.ExceptionInInitializerError

        at org.gradle.api.internal.classloading.GroovySystemLoaderFactory.forClassLoader(GroovySystemLoaderFactory.java:44)

        at org.gradle.api.internal.project.antbuilder.ClassPathToClassLoaderCache.withCachedClassLoader(ClassPathToClassLoaderCache.java:115)

        at org.gradle.api.internal.project.antbuilder.DefaultIsolatedAntBuilder.execute(DefaultIsolatedAntBuilder.java:127)

        at org.gradle.api.internal.tasks.AntGroovydoc.getGroovyVersion(AntGroovydoc.java:113)

        at org.gradle.api.internal.tasks.AntGroovydoc.execute(AntGroovydoc.java:74)

        at org.gradle.api.tasks.javadoc.Groovydoc.generate(Groovydoc.java:98)

        at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.doExecute(DefaultTaskClassInfoStore.java:141)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:134)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:123)

        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:632)

        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:615)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:95)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:76)

        ... 70 more

Caused by: groovy.lang.GroovyRuntimeException: Unable to load module META-INF descriptor

        ... 84 more

Caused by: java.io.FileNotFoundException: JAR entry META-INF/services/org.codehaus.groovy.runtime.ExtensionModule not found in /Users/glaforge/Downloads/groovy-2.4.10/subprojects/groovy-xml/target/libs/groovy-xml-2.4.10.jar

        ... 84 more



BUILD FAILED


On Tue, Mar 14, 2017 at 6:13 AM, Paul King <[hidden email]> wrote:
Okay, I am going to cancel the vote and try again with the commit
removed for the issue John found. I'll have to work out why one of my
CI builds didn't trigger that error.

I'll start a new vote shortly. Cédric/Guillaume, I'm keen for any
further feedback on why you were having issues with the 'dist' task.
That remains unexplained and unreproducible from my end.

Cheers, Paul.

On Mon, Mar 13, 2017 at 5:16 PM, Paul King <[hidden email]> wrote:
> Hi John,
>
> I did a bit more testing for the non-spock case and perhaps there is
> an issue there. I'll see if Jochen or Cédric have a little more
> knowledge on whether that case should be allowed. Certainly some paths
> give you ClassFormatError with the dot in the name but there seems to
> be other paths which may not depending on how you run it - like the
> test you showed.
>
> Cheers, Paul.
>
> On Mon, Mar 13, 2017 at 10:38 AM, Paul King <[hidden email]> wrote:
>> Hi John, the Spock example is fine since that isn't left as the method
>> name by the time the test is run. I am puzzled how the other one could
>> have ever run.
>>
>> Cheers, Paul.
>>
>> On Sun, Mar 12, 2017 at 9:28 AM, John Wagenleitner
>> <[hidden email]> wrote:
>>> +1
>>>
>>> Just wanted to note that in testing I came across some method names in tests
>>> that had characters that are now no longer allowed in method names [1] [2].
>>> I know this is related to the fix for GROOVY-6792, just thought it was odd
>>> that it seems to have worked in some cases before.
>>>
>>> [1]
>>> https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-test-suite-web/src/test/groovy/org/grails/web/codecs/CodecSpec.groovy#L40
>>>
>>> [2]
>>> https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-core/src/test/groovy/org/grails/compiler/injection/DefaultDomainClassInjectorSpec.groovy#L17
>>>
>>> On Thu, Mar 9, 2017 at 2:29 PM, Paul King <[hidden email]> wrote:
>>>>
>>>> Dear community,
>>>>
>>>> I am happy to start the VOTE thread for a Groovy 2.4.10 release!
>>>>
>>>> This release includes 9 bug fixes/improvements as outlined in the
>>>> changelog:
>>>>
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12339743
>>>>
>>>> Tag:
>>>> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_4_10
>>>> Tag commit id: f2796bad0c5e5d1304e51331244b671ece60c351
>>>>
>>>> The artifacts to be voted on are located as follows (r18648).
>>>> Source release:
>>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/sources
>>>> Convenience binaries:
>>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/distribution
>>>>
>>>> Release artifacts are signed with a key from the following file:
>>>> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>>>>
>>>> Please vote on releasing this package as Apache Groovy 2.4.10.
>>>>
>>>> The vote is open for the next 72 hours and passes if a majority of at
>>>> least three +1 PMC votes are cast.
>>>>
>>>> [ ] +1 Release Apache Groovy 2.4.10
>>>> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
>>>> [ ] -1 Do not release Apache Groovy 2.4.10 because...
>>>>
>>>> Here is my vote:
>>>>
>>>> +1 (binding)
>>>
>>>



--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform






--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform




--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform




--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform

Reply | Threaded
Open this post in threaded view
|

Re: [CANCEL][VOTE] Release Apache Groovy 2.4.10

Guillaume Laforge
Administrator
Last words...
Following the build instructions properly, and use "gradle" to let it create the wrapper (rather than calling "gradle wrapper" which creates a different version of the wrapper), the build works successfully for me.

On Tue, Mar 14, 2017 at 12:36 PM, Guillaume Laforge <[hidden email]> wrote:
Rebuilding from a fresh source zip, using gradlew, I still get the error:

* What went wrong:

Execution failed for task ':groovydocAll'.

> java.lang.VerifyError: Bad type on operand stack

  Exception Details:

    Location:

      org/codehaus/groovy/tools/groovydoc/GroovyRootDocBuilder.getJavaParser(Ljava/lang/String;Lorg/codehaus/groovy/antlr/SourceBuffer;)Lorg/codehaus/groovy/antlr/java/JavaRecognizer; @28: invokevirtual

    Reason:

      Type 'org/codehaus/groovy/antlr/java/JavaLexer' (current frame, stack[1]) is not assignable to 'groovyjarjarantlr/CharScanner'

    Current Frame:

      bci: @28

      flags: { }

      locals: { 'java/lang/String', 'org/codehaus/groovy/antlr/SourceBuffer', 'org/codehaus/groovy/antlr/UnicodeEscapingReader', 'org/codehaus/groovy/antlr/java/JavaLexer' }

      stack: { 'org/codehaus/groovy/antlr/UnicodeEscapingReader', 'org/codehaus/groovy/antlr/java/JavaLexer' }

    Bytecode:

      0x0000000: bb00 bb59 bb00 bd59 2ab7 00be 2bb7 00c1

      0x0000010: 4dbb 00c3 592c b700 c64e 2c2d b600 ca2d

      0x0000020: b800 ce3a 0419 042b b600 d219 04b0  


On Tue, Mar 14, 2017 at 12:23 PM, Guillaume Laforge <[hidden email]> wrote:
And with gradlew, in spite of a clean, doing dist gives me tons of those AntlrParserPlugin errors :-O

:compileJava

warning: [options] bootstrap class path not set in conjunction with -source 1.6

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/ast/tools/GenericsUtils.java:26: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyLexer;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/ast/tools/GenericsUtils.java:27: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyRecognizer;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/AntlrParserPlugin.java:26: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyLexer;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/AntlrParserPlugin.java:27: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyRecognizer;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/AntlrParserPlugin.java:28: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyTokenTypes;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/AntlrParserPlugin.java:58: error: cannot find symbol

public class AntlrParserPlugin extends ASTHelper implements ParserPlugin, GroovyTokenTypes {

                                                                          ^

  symbol: class GroovyTokenTypes

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/java/Groovifier.java:22: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyTokenTypes;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/java/Groovifier.java:25: error: cannot find symbol

public class Groovifier extends VisitorAdapter implements GroovyTokenTypes {

                                                          ^

  symbol: class GroovyTokenTypes

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/java/Java2GroovyConverter.java:22: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyTokenTypes;

                                       ^


On Tue, Mar 14, 2017 at 12:21 PM, Guillaume Laforge <[hidden email]> wrote:
There's indeed a problem with cleanliness.
I get Antlr related problems in AntlrParserPlugin when not cleaning.

I'm gonna try with the wrapper, just in case, as suggested by Paul.

On Tue, Mar 14, 2017 at 11:12 AM, Cédric Champeau <[hidden email]> wrote:
Actually got the same error as Guillaume using Gradle 2.3: https://gradle.com/s/5d6oqw3wsbtny

There's something wrong with the build somehow. I guess this one happens when the build isn't clean. It definitely needs a rewrite to benefit from all the latest Gradle nifties.


2017-03-14 10:53 GMT+01:00 Cédric Champeau <[hidden email]>:
I think the error comes from using the latest Gradle release with the 2.4.x branch: they don't seem to be compatible. Master uses latest Gradle, not 2.4.x.

2017-03-14 9:01 GMT+01:00 Guillaume Laforge <[hidden email]>:
I upgraded my local Groovy and Gradle to the latest SDKman-available versions (2.4.9 and 3.4.1 respectively).
Re-launching the dist build with --stacktrace, I have something different now...

:groovydocAll FAILED


FAILURE: Build failed with an exception.


* What went wrong:

Execution failed for task ':groovydocAll'.

> java.lang.ExceptionInInitializerError (no error message)


* Try:

Run with --info or --debug option to get more log output.


* Exception is:

org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':groovydocAll'.

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:84)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:55)

        at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:62)

        at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)

        at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:88)

        at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:46)

        at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:51)

        at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)

        at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)

        at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:236)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:228)

        at org.gradle.internal.Transformers$4.transform(Transformers.java:169)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:61)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:228)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:215)

        at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.processTask(AbstractTaskPlanExecutor.java:77)

        at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.run(AbstractTaskPlanExecutor.java:58)

        at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor.process(DefaultTaskPlanExecutor.java:32)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter.execute(DefaultTaskGraphExecuter.java:113)

        at org.gradle.execution.SelectedTaskExecutionAction.execute(SelectedTaskExecutionAction.java:37)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)

        at org.gradle.execution.DefaultBuildExecuter.access$000(DefaultBuildExecuter.java:23)

        at org.gradle.execution.DefaultBuildExecuter$1.proceed(DefaultBuildExecuter.java:43)

        at org.gradle.execution.DryRunBuildExecutionAction.execute(DryRunBuildExecutionAction.java:32)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:30)

        at org.gradle.initialization.DefaultGradleLauncher$RunTasksAction.execute(DefaultGradleLauncher.java:256)

        at org.gradle.initialization.DefaultGradleLauncher$RunTasksAction.execute(DefaultGradleLauncher.java:253)

        at org.gradle.internal.Transformers$4.transform(Transformers.java:169)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:56)

        at org.gradle.initialization.DefaultGradleLauncher.doBuildStages(DefaultGradleLauncher.java:175)

        at org.gradle.initialization.DefaultGradleLauncher.doBuild(DefaultGradleLauncher.java:119)

        at org.gradle.initialization.DefaultGradleLauncher.run(DefaultGradleLauncher.java:102)

        at org.gradle.launcher.exec.GradleBuildController.run(GradleBuildController.java:71)

        at org.gradle.tooling.internal.provider.ExecuteBuildActionRunner.run(ExecuteBuildActionRunner.java:28)

        at org.gradle.launcher.exec.ChainingBuildActionRunner.run(ChainingBuildActionRunner.java:35)

        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:41)

        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:26)

        at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:75)

        at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:49)

        at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:49)

        at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:31)

        at org.gradle.launcher.daemon.server.exec.ExecuteBuild.doBuild(ExecuteBuild.java:67)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.WatchForDisconnection.execute(WatchForDisconnection.java:47)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.ResetDeprecationLogger.execute(ResetDeprecationLogger.java:26)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.RequestStopIfSingleUsedDaemon.execute(RequestStopIfSingleUsedDaemon.java:34)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:74)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:72)

        at org.gradle.util.Swapper.swap(Swapper.java:38)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput.execute(ForwardClientInput.java:72)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.LogAndCheckHealth.execute(LogAndCheckHealth.java:55)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.LogToClient.doBuild(LogToClient.java:60)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.EstablishBuildEnvironment.doBuild(EstablishBuildEnvironment.java:72)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.StartBuildOrRespondWithBusy$1.run(StartBuildOrRespondWithBusy.java:50)

        at org.gradle.launcher.daemon.server.DaemonStateCoordinator$1.run(DaemonStateCoordinator.java:297)

        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)

        at org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:46)

Caused by: java.lang.ExceptionInInitializerError

        at org.gradle.api.internal.classloading.GroovySystemLoaderFactory.forClassLoader(GroovySystemLoaderFactory.java:44)

        at org.gradle.api.internal.project.antbuilder.ClassPathToClassLoaderCache.withCachedClassLoader(ClassPathToClassLoaderCache.java:115)

        at org.gradle.api.internal.project.antbuilder.DefaultIsolatedAntBuilder.execute(DefaultIsolatedAntBuilder.java:127)

        at org.gradle.api.internal.tasks.AntGroovydoc.getGroovyVersion(AntGroovydoc.java:113)

        at org.gradle.api.internal.tasks.AntGroovydoc.execute(AntGroovydoc.java:74)

        at org.gradle.api.tasks.javadoc.Groovydoc.generate(Groovydoc.java:98)

        at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.doExecute(DefaultTaskClassInfoStore.java:141)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:134)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:123)

        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:632)

        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:615)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:95)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:76)

        ... 70 more

Caused by: groovy.lang.GroovyRuntimeException: Unable to load module META-INF descriptor

        ... 84 more

Caused by: java.io.FileNotFoundException: JAR entry META-INF/services/org.codehaus.groovy.runtime.ExtensionModule not found in /Users/glaforge/Downloads/groovy-2.4.10/subprojects/groovy-xml/target/libs/groovy-xml-2.4.10.jar

        ... 84 more



BUILD FAILED


On Tue, Mar 14, 2017 at 6:13 AM, Paul King <[hidden email]> wrote:
Okay, I am going to cancel the vote and try again with the commit
removed for the issue John found. I'll have to work out why one of my
CI builds didn't trigger that error.

I'll start a new vote shortly. Cédric/Guillaume, I'm keen for any
further feedback on why you were having issues with the 'dist' task.
That remains unexplained and unreproducible from my end.

Cheers, Paul.

On Mon, Mar 13, 2017 at 5:16 PM, Paul King <[hidden email]> wrote:
> Hi John,
>
> I did a bit more testing for the non-spock case and perhaps there is
> an issue there. I'll see if Jochen or Cédric have a little more
> knowledge on whether that case should be allowed. Certainly some paths
> give you ClassFormatError with the dot in the name but there seems to
> be other paths which may not depending on how you run it - like the
> test you showed.
>
> Cheers, Paul.
>
> On Mon, Mar 13, 2017 at 10:38 AM, Paul King <[hidden email]> wrote:
>> Hi John, the Spock example is fine since that isn't left as the method
>> name by the time the test is run. I am puzzled how the other one could
>> have ever run.
>>
>> Cheers, Paul.
>>
>> On Sun, Mar 12, 2017 at 9:28 AM, John Wagenleitner
>> <[hidden email]> wrote:
>>> +1
>>>
>>> Just wanted to note that in testing I came across some method names in tests
>>> that had characters that are now no longer allowed in method names [1] [2].
>>> I know this is related to the fix for GROOVY-6792, just thought it was odd
>>> that it seems to have worked in some cases before.
>>>
>>> [1]
>>> https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-test-suite-web/src/test/groovy/org/grails/web/codecs/CodecSpec.groovy#L40
>>>
>>> [2]
>>> https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-core/src/test/groovy/org/grails/compiler/injection/DefaultDomainClassInjectorSpec.groovy#L17
>>>
>>> On Thu, Mar 9, 2017 at 2:29 PM, Paul King <[hidden email]> wrote:
>>>>
>>>> Dear community,
>>>>
>>>> I am happy to start the VOTE thread for a Groovy 2.4.10 release!
>>>>
>>>> This release includes 9 bug fixes/improvements as outlined in the
>>>> changelog:
>>>>
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12339743
>>>>
>>>> Tag:
>>>> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_4_10
>>>> Tag commit id: f2796bad0c5e5d1304e51331244b671ece60c351
>>>>
>>>> The artifacts to be voted on are located as follows (r18648).
>>>> Source release:
>>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/sources
>>>> Convenience binaries:
>>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/distribution
>>>>
>>>> Release artifacts are signed with a key from the following file:
>>>> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>>>>
>>>> Please vote on releasing this package as Apache Groovy 2.4.10.
>>>>
>>>> The vote is open for the next 72 hours and passes if a majority of at
>>>> least three +1 PMC votes are cast.
>>>>
>>>> [ ] +1 Release Apache Groovy 2.4.10
>>>> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
>>>> [ ] -1 Do not release Apache Groovy 2.4.10 because...
>>>>
>>>> Here is my vote:
>>>>
>>>> +1 (binding)
>>>
>>>



--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform






--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform




--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform




--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform




--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform

Reply | Threaded
Open this post in threaded view
|

Re: [CANCEL][VOTE] Release Apache Groovy 2.4.10

Marcin Erdmann
Following instructions and reading documentation instead of relying on one's assumptions? Why on earth would you do that? ;)

On Tue, Mar 14, 2017 at 12:49 PM, Guillaume Laforge <[hidden email]> wrote:
Last words...
Following the build instructions properly, and use "gradle" to let it create the wrapper (rather than calling "gradle wrapper" which creates a different version of the wrapper), the build works successfully for me.

On Tue, Mar 14, 2017 at 12:36 PM, Guillaume Laforge <[hidden email]> wrote:
Rebuilding from a fresh source zip, using gradlew, I still get the error:

* What went wrong:

Execution failed for task ':groovydocAll'.

> java.lang.VerifyError: Bad type on operand stack

  Exception Details:

    Location:

      org/codehaus/groovy/tools/groovydoc/GroovyRootDocBuilder.getJavaParser(Ljava/lang/String;Lorg/codehaus/groovy/antlr/SourceBuffer;)Lorg/codehaus/groovy/antlr/java/JavaRecognizer; @28: invokevirtual

    Reason:

      Type 'org/codehaus/groovy/antlr/java/JavaLexer' (current frame, stack[1]) is not assignable to 'groovyjarjarantlr/CharScanner'

    Current Frame:

      bci: @28

      flags: { }

      locals: { 'java/lang/String', 'org/codehaus/groovy/antlr/SourceBuffer', 'org/codehaus/groovy/antlr/UnicodeEscapingReader', 'org/codehaus/groovy/antlr/java/JavaLexer' }

      stack: { 'org/codehaus/groovy/antlr/UnicodeEscapingReader', 'org/codehaus/groovy/antlr/java/JavaLexer' }

    Bytecode:

      0x0000000: bb00 bb59 bb00 bd59 2ab7 00be 2bb7 00c1

      0x0000010: 4dbb 00c3 592c b700 c64e 2c2d b600 ca2d

      0x0000020: b800 ce3a 0419 042b b600 d219 04b0  


On Tue, Mar 14, 2017 at 12:23 PM, Guillaume Laforge <[hidden email]> wrote:
And with gradlew, in spite of a clean, doing dist gives me tons of those AntlrParserPlugin errors :-O

:compileJava

warning: [options] bootstrap class path not set in conjunction with -source 1.6

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/ast/tools/GenericsUtils.java:26: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyLexer;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/ast/tools/GenericsUtils.java:27: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyRecognizer;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/AntlrParserPlugin.java:26: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyLexer;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/AntlrParserPlugin.java:27: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyRecognizer;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/AntlrParserPlugin.java:28: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyTokenTypes;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/AntlrParserPlugin.java:58: error: cannot find symbol

public class AntlrParserPlugin extends ASTHelper implements ParserPlugin, GroovyTokenTypes {

                                                                          ^

  symbol: class GroovyTokenTypes

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/java/Groovifier.java:22: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyTokenTypes;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/java/Groovifier.java:25: error: cannot find symbol

public class Groovifier extends VisitorAdapter implements GroovyTokenTypes {

                                                          ^

  symbol: class GroovyTokenTypes

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/java/Java2GroovyConverter.java:22: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyTokenTypes;

                                       ^


On Tue, Mar 14, 2017 at 12:21 PM, Guillaume Laforge <[hidden email]> wrote:
There's indeed a problem with cleanliness.
I get Antlr related problems in AntlrParserPlugin when not cleaning.

I'm gonna try with the wrapper, just in case, as suggested by Paul.

On Tue, Mar 14, 2017 at 11:12 AM, Cédric Champeau <[hidden email]> wrote:
Actually got the same error as Guillaume using Gradle 2.3: https://gradle.com/s/5d6oqw3wsbtny

There's something wrong with the build somehow. I guess this one happens when the build isn't clean. It definitely needs a rewrite to benefit from all the latest Gradle nifties.


2017-03-14 10:53 GMT+01:00 Cédric Champeau <[hidden email]>:
I think the error comes from using the latest Gradle release with the 2.4.x branch: they don't seem to be compatible. Master uses latest Gradle, not 2.4.x.

2017-03-14 9:01 GMT+01:00 Guillaume Laforge <[hidden email]>:
I upgraded my local Groovy and Gradle to the latest SDKman-available versions (2.4.9 and 3.4.1 respectively).
Re-launching the dist build with --stacktrace, I have something different now...

:groovydocAll FAILED


FAILURE: Build failed with an exception.


* What went wrong:

Execution failed for task ':groovydocAll'.

> java.lang.ExceptionInInitializerError (no error message)


* Try:

Run with --info or --debug option to get more log output.


* Exception is:

org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':groovydocAll'.

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:84)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:55)

        at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:62)

        at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)

        at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:88)

        at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:46)

        at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:51)

        at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)

        at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)

        at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:236)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:228)

        at org.gradle.internal.Transformers$4.transform(Transformers.java:169)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:61)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:228)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:215)

        at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.processTask(AbstractTaskPlanExecutor.java:77)

        at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.run(AbstractTaskPlanExecutor.java:58)

        at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor.process(DefaultTaskPlanExecutor.java:32)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter.execute(DefaultTaskGraphExecuter.java:113)

        at org.gradle.execution.SelectedTaskExecutionAction.execute(SelectedTaskExecutionAction.java:37)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)

        at org.gradle.execution.DefaultBuildExecuter.access$000(DefaultBuildExecuter.java:23)

        at org.gradle.execution.DefaultBuildExecuter$1.proceed(DefaultBuildExecuter.java:43)

        at org.gradle.execution.DryRunBuildExecutionAction.execute(DryRunBuildExecutionAction.java:32)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:30)

        at org.gradle.initialization.DefaultGradleLauncher$RunTasksAction.execute(DefaultGradleLauncher.java:256)

        at org.gradle.initialization.DefaultGradleLauncher$RunTasksAction.execute(DefaultGradleLauncher.java:253)

        at org.gradle.internal.Transformers$4.transform(Transformers.java:169)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:56)

        at org.gradle.initialization.DefaultGradleLauncher.doBuildStages(DefaultGradleLauncher.java:175)

        at org.gradle.initialization.DefaultGradleLauncher.doBuild(DefaultGradleLauncher.java:119)

        at org.gradle.initialization.DefaultGradleLauncher.run(DefaultGradleLauncher.java:102)

        at org.gradle.launcher.exec.GradleBuildController.run(GradleBuildController.java:71)

        at org.gradle.tooling.internal.provider.ExecuteBuildActionRunner.run(ExecuteBuildActionRunner.java:28)

        at org.gradle.launcher.exec.ChainingBuildActionRunner.run(ChainingBuildActionRunner.java:35)

        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:41)

        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:26)

        at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:75)

        at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:49)

        at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:49)

        at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:31)

        at org.gradle.launcher.daemon.server.exec.ExecuteBuild.doBuild(ExecuteBuild.java:67)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.WatchForDisconnection.execute(WatchForDisconnection.java:47)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.ResetDeprecationLogger.execute(ResetDeprecationLogger.java:26)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.RequestStopIfSingleUsedDaemon.execute(RequestStopIfSingleUsedDaemon.java:34)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:74)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:72)

        at org.gradle.util.Swapper.swap(Swapper.java:38)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput.execute(ForwardClientInput.java:72)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.LogAndCheckHealth.execute(LogAndCheckHealth.java:55)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.LogToClient.doBuild(LogToClient.java:60)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.EstablishBuildEnvironment.doBuild(EstablishBuildEnvironment.java:72)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.StartBuildOrRespondWithBusy$1.run(StartBuildOrRespondWithBusy.java:50)

        at org.gradle.launcher.daemon.server.DaemonStateCoordinator$1.run(DaemonStateCoordinator.java:297)

        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)

        at org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:46)

Caused by: java.lang.ExceptionInInitializerError

        at org.gradle.api.internal.classloading.GroovySystemLoaderFactory.forClassLoader(GroovySystemLoaderFactory.java:44)

        at org.gradle.api.internal.project.antbuilder.ClassPathToClassLoaderCache.withCachedClassLoader(ClassPathToClassLoaderCache.java:115)

        at org.gradle.api.internal.project.antbuilder.DefaultIsolatedAntBuilder.execute(DefaultIsolatedAntBuilder.java:127)

        at org.gradle.api.internal.tasks.AntGroovydoc.getGroovyVersion(AntGroovydoc.java:113)

        at org.gradle.api.internal.tasks.AntGroovydoc.execute(AntGroovydoc.java:74)

        at org.gradle.api.tasks.javadoc.Groovydoc.generate(Groovydoc.java:98)

        at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.doExecute(DefaultTaskClassInfoStore.java:141)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:134)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:123)

        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:632)

        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:615)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:95)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:76)

        ... 70 more

Caused by: groovy.lang.GroovyRuntimeException: Unable to load module META-INF descriptor

        ... 84 more

Caused by: java.io.FileNotFoundException: JAR entry META-INF/services/org.codehaus.groovy.runtime.ExtensionModule not found in /Users/glaforge/Downloads/groovy-2.4.10/subprojects/groovy-xml/target/libs/groovy-xml-2.4.10.jar

        ... 84 more



BUILD FAILED


On Tue, Mar 14, 2017 at 6:13 AM, Paul King <[hidden email]> wrote:
Okay, I am going to cancel the vote and try again with the commit
removed for the issue John found. I'll have to work out why one of my
CI builds didn't trigger that error.

I'll start a new vote shortly. Cédric/Guillaume, I'm keen for any
further feedback on why you were having issues with the 'dist' task.
That remains unexplained and unreproducible from my end.

Cheers, Paul.

On Mon, Mar 13, 2017 at 5:16 PM, Paul King <[hidden email]> wrote:
> Hi John,
>
> I did a bit more testing for the non-spock case and perhaps there is
> an issue there. I'll see if Jochen or Cédric have a little more
> knowledge on whether that case should be allowed. Certainly some paths
> give you ClassFormatError with the dot in the name but there seems to
> be other paths which may not depending on how you run it - like the
> test you showed.
>
> Cheers, Paul.
>
> On Mon, Mar 13, 2017 at 10:38 AM, Paul King <[hidden email]> wrote:
>> Hi John, the Spock example is fine since that isn't left as the method
>> name by the time the test is run. I am puzzled how the other one could
>> have ever run.
>>
>> Cheers, Paul.
>>
>> On Sun, Mar 12, 2017 at 9:28 AM, John Wagenleitner
>> <[hidden email]> wrote:
>>> +1
>>>
>>> Just wanted to note that in testing I came across some method names in tests
>>> that had characters that are now no longer allowed in method names [1] [2].
>>> I know this is related to the fix for GROOVY-6792, just thought it was odd
>>> that it seems to have worked in some cases before.
>>>
>>> [1]
>>> https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-test-suite-web/src/test/groovy/org/grails/web/codecs/CodecSpec.groovy#L40
>>>
>>> [2]
>>> https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-core/src/test/groovy/org/grails/compiler/injection/DefaultDomainClassInjectorSpec.groovy#L17
>>>
>>> On Thu, Mar 9, 2017 at 2:29 PM, Paul King <[hidden email]> wrote:
>>>>
>>>> Dear community,
>>>>
>>>> I am happy to start the VOTE thread for a Groovy 2.4.10 release!
>>>>
>>>> This release includes 9 bug fixes/improvements as outlined in the
>>>> changelog:
>>>>
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12339743
>>>>
>>>> Tag:
>>>> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_4_10
>>>> Tag commit id: f2796bad0c5e5d1304e51331244b671ece60c351
>>>>
>>>> The artifacts to be voted on are located as follows (r18648).
>>>> Source release:
>>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/sources
>>>> Convenience binaries:
>>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/distribution
>>>>
>>>> Release artifacts are signed with a key from the following file:
>>>> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>>>>
>>>> Please vote on releasing this package as Apache Groovy 2.4.10.
>>>>
>>>> The vote is open for the next 72 hours and passes if a majority of at
>>>> least three +1 PMC votes are cast.
>>>>
>>>> [ ] +1 Release Apache Groovy 2.4.10
>>>> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
>>>> [ ] -1 Do not release Apache Groovy 2.4.10 because...
>>>>
>>>> Here is my vote:
>>>>
>>>> +1 (binding)
>>>
>>>



--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform






--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform




--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform




--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform




--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform


Reply | Threaded
Open this post in threaded view
|

Re: [CANCEL][VOTE] Release Apache Groovy 2.4.10

Guillaume Laforge
Administrator
Why would one ever read TFM??? come on!!! ;-)

On Tue, Mar 14, 2017 at 1:58 PM, Marcin Erdmann <[hidden email]> wrote:
Following instructions and reading documentation instead of relying on one's assumptions? Why on earth would you do that? ;)

On Tue, Mar 14, 2017 at 12:49 PM, Guillaume Laforge <[hidden email]> wrote:
Last words...
Following the build instructions properly, and use "gradle" to let it create the wrapper (rather than calling "gradle wrapper" which creates a different version of the wrapper), the build works successfully for me.

On Tue, Mar 14, 2017 at 12:36 PM, Guillaume Laforge <[hidden email]> wrote:
Rebuilding from a fresh source zip, using gradlew, I still get the error:

* What went wrong:

Execution failed for task ':groovydocAll'.

> java.lang.VerifyError: Bad type on operand stack

  Exception Details:

    Location:

      org/codehaus/groovy/tools/groovydoc/GroovyRootDocBuilder.getJavaParser(Ljava/lang/String;Lorg/codehaus/groovy/antlr/SourceBuffer;)Lorg/codehaus/groovy/antlr/java/JavaRecognizer; @28: invokevirtual

    Reason:

      Type 'org/codehaus/groovy/antlr/java/JavaLexer' (current frame, stack[1]) is not assignable to 'groovyjarjarantlr/CharScanner'

    Current Frame:

      bci: @28

      flags: { }

      locals: { 'java/lang/String', 'org/codehaus/groovy/antlr/SourceBuffer', 'org/codehaus/groovy/antlr/UnicodeEscapingReader', 'org/codehaus/groovy/antlr/java/JavaLexer' }

      stack: { 'org/codehaus/groovy/antlr/UnicodeEscapingReader', 'org/codehaus/groovy/antlr/java/JavaLexer' }

    Bytecode:

      0x0000000: bb00 bb59 bb00 bd59 2ab7 00be 2bb7 00c1

      0x0000010: 4dbb 00c3 592c b700 c64e 2c2d b600 ca2d

      0x0000020: b800 ce3a 0419 042b b600 d219 04b0  


On Tue, Mar 14, 2017 at 12:23 PM, Guillaume Laforge <[hidden email]> wrote:
And with gradlew, in spite of a clean, doing dist gives me tons of those AntlrParserPlugin errors :-O

:compileJava

warning: [options] bootstrap class path not set in conjunction with -source 1.6

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/ast/tools/GenericsUtils.java:26: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyLexer;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/ast/tools/GenericsUtils.java:27: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyRecognizer;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/AntlrParserPlugin.java:26: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyLexer;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/AntlrParserPlugin.java:27: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyRecognizer;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/AntlrParserPlugin.java:28: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyTokenTypes;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/AntlrParserPlugin.java:58: error: cannot find symbol

public class AntlrParserPlugin extends ASTHelper implements ParserPlugin, GroovyTokenTypes {

                                                                          ^

  symbol: class GroovyTokenTypes

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/java/Groovifier.java:22: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyTokenTypes;

                                       ^

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/java/Groovifier.java:25: error: cannot find symbol

public class Groovifier extends VisitorAdapter implements GroovyTokenTypes {

                                                          ^

  symbol: class GroovyTokenTypes

/Users/glaforge/Downloads/groovy-2.4.10/src/main/org/codehaus/groovy/antlr/java/Java2GroovyConverter.java:22: error: package org.codehaus.groovy.antlr.parser does not exist

import org.codehaus.groovy.antlr.parser.GroovyTokenTypes;

                                       ^


On Tue, Mar 14, 2017 at 12:21 PM, Guillaume Laforge <[hidden email]> wrote:
There's indeed a problem with cleanliness.
I get Antlr related problems in AntlrParserPlugin when not cleaning.

I'm gonna try with the wrapper, just in case, as suggested by Paul.

On Tue, Mar 14, 2017 at 11:12 AM, Cédric Champeau <[hidden email]> wrote:
Actually got the same error as Guillaume using Gradle 2.3: https://gradle.com/s/5d6oqw3wsbtny

There's something wrong with the build somehow. I guess this one happens when the build isn't clean. It definitely needs a rewrite to benefit from all the latest Gradle nifties.


2017-03-14 10:53 GMT+01:00 Cédric Champeau <[hidden email]>:
I think the error comes from using the latest Gradle release with the 2.4.x branch: they don't seem to be compatible. Master uses latest Gradle, not 2.4.x.

2017-03-14 9:01 GMT+01:00 Guillaume Laforge <[hidden email]>:
I upgraded my local Groovy and Gradle to the latest SDKman-available versions (2.4.9 and 3.4.1 respectively).
Re-launching the dist build with --stacktrace, I have something different now...

:groovydocAll FAILED


FAILURE: Build failed with an exception.


* What went wrong:

Execution failed for task ':groovydocAll'.

> java.lang.ExceptionInInitializerError (no error message)


* Try:

Run with --info or --debug option to get more log output.


* Exception is:

org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':groovydocAll'.

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:84)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:55)

        at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:62)

        at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)

        at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:88)

        at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:46)

        at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:51)

        at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)

        at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)

        at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:236)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:228)

        at org.gradle.internal.Transformers$4.transform(Transformers.java:169)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:61)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:228)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:215)

        at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.processTask(AbstractTaskPlanExecutor.java:77)

        at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.run(AbstractTaskPlanExecutor.java:58)

        at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor.process(DefaultTaskPlanExecutor.java:32)

        at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter.execute(DefaultTaskGraphExecuter.java:113)

        at org.gradle.execution.SelectedTaskExecutionAction.execute(SelectedTaskExecutionAction.java:37)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)

        at org.gradle.execution.DefaultBuildExecuter.access$000(DefaultBuildExecuter.java:23)

        at org.gradle.execution.DefaultBuildExecuter$1.proceed(DefaultBuildExecuter.java:43)

        at org.gradle.execution.DryRunBuildExecutionAction.execute(DryRunBuildExecutionAction.java:32)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)

        at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:30)

        at org.gradle.initialization.DefaultGradleLauncher$RunTasksAction.execute(DefaultGradleLauncher.java:256)

        at org.gradle.initialization.DefaultGradleLauncher$RunTasksAction.execute(DefaultGradleLauncher.java:253)

        at org.gradle.internal.Transformers$4.transform(Transformers.java:169)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)

        at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:56)

        at org.gradle.initialization.DefaultGradleLauncher.doBuildStages(DefaultGradleLauncher.java:175)

        at org.gradle.initialization.DefaultGradleLauncher.doBuild(DefaultGradleLauncher.java:119)

        at org.gradle.initialization.DefaultGradleLauncher.run(DefaultGradleLauncher.java:102)

        at org.gradle.launcher.exec.GradleBuildController.run(GradleBuildController.java:71)

        at org.gradle.tooling.internal.provider.ExecuteBuildActionRunner.run(ExecuteBuildActionRunner.java:28)

        at org.gradle.launcher.exec.ChainingBuildActionRunner.run(ChainingBuildActionRunner.java:35)

        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:41)

        at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:26)

        at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:75)

        at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:49)

        at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:49)

        at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:31)

        at org.gradle.launcher.daemon.server.exec.ExecuteBuild.doBuild(ExecuteBuild.java:67)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.WatchForDisconnection.execute(WatchForDisconnection.java:47)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.ResetDeprecationLogger.execute(ResetDeprecationLogger.java:26)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.RequestStopIfSingleUsedDaemon.execute(RequestStopIfSingleUsedDaemon.java:34)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:74)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:72)

        at org.gradle.util.Swapper.swap(Swapper.java:38)

        at org.gradle.launcher.daemon.server.exec.ForwardClientInput.execute(ForwardClientInput.java:72)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.LogAndCheckHealth.execute(LogAndCheckHealth.java:55)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.LogToClient.doBuild(LogToClient.java:60)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.EstablishBuildEnvironment.doBuild(EstablishBuildEnvironment.java:72)

        at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)

        at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)

        at org.gradle.launcher.daemon.server.exec.StartBuildOrRespondWithBusy$1.run(StartBuildOrRespondWithBusy.java:50)

        at org.gradle.launcher.daemon.server.DaemonStateCoordinator$1.run(DaemonStateCoordinator.java:297)

        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)

        at org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:46)

Caused by: java.lang.ExceptionInInitializerError

        at org.gradle.api.internal.classloading.GroovySystemLoaderFactory.forClassLoader(GroovySystemLoaderFactory.java:44)

        at org.gradle.api.internal.project.antbuilder.ClassPathToClassLoaderCache.withCachedClassLoader(ClassPathToClassLoaderCache.java:115)

        at org.gradle.api.internal.project.antbuilder.DefaultIsolatedAntBuilder.execute(DefaultIsolatedAntBuilder.java:127)

        at org.gradle.api.internal.tasks.AntGroovydoc.getGroovyVersion(AntGroovydoc.java:113)

        at org.gradle.api.internal.tasks.AntGroovydoc.execute(AntGroovydoc.java:74)

        at org.gradle.api.tasks.javadoc.Groovydoc.generate(Groovydoc.java:98)

        at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.doExecute(DefaultTaskClassInfoStore.java:141)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:134)

        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:123)

        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:632)

        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:615)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:95)

        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:76)

        ... 70 more

Caused by: groovy.lang.GroovyRuntimeException: Unable to load module META-INF descriptor

        ... 84 more

Caused by: java.io.FileNotFoundException: JAR entry META-INF/services/org.codehaus.groovy.runtime.ExtensionModule not found in /Users/glaforge/Downloads/groovy-2.4.10/subprojects/groovy-xml/target/libs/groovy-xml-2.4.10.jar

        ... 84 more



BUILD FAILED


On Tue, Mar 14, 2017 at 6:13 AM, Paul King <[hidden email]> wrote:
Okay, I am going to cancel the vote and try again with the commit
removed for the issue John found. I'll have to work out why one of my
CI builds didn't trigger that error.

I'll start a new vote shortly. Cédric/Guillaume, I'm keen for any
further feedback on why you were having issues with the 'dist' task.
That remains unexplained and unreproducible from my end.

Cheers, Paul.

On Mon, Mar 13, 2017 at 5:16 PM, Paul King <[hidden email]> wrote:
> Hi John,
>
> I did a bit more testing for the non-spock case and perhaps there is
> an issue there. I'll see if Jochen or Cédric have a little more
> knowledge on whether that case should be allowed. Certainly some paths
> give you ClassFormatError with the dot in the name but there seems to
> be other paths which may not depending on how you run it - like the
> test you showed.
>
> Cheers, Paul.
>
> On Mon, Mar 13, 2017 at 10:38 AM, Paul King <[hidden email]> wrote:
>> Hi John, the Spock example is fine since that isn't left as the method
>> name by the time the test is run. I am puzzled how the other one could
>> have ever run.
>>
>> Cheers, Paul.
>>
>> On Sun, Mar 12, 2017 at 9:28 AM, John Wagenleitner
>> <[hidden email]> wrote:
>>> +1
>>>
>>> Just wanted to note that in testing I came across some method names in tests
>>> that had characters that are now no longer allowed in method names [1] [2].
>>> I know this is related to the fix for GROOVY-6792, just thought it was odd
>>> that it seems to have worked in some cases before.
>>>
>>> [1]
>>> https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-test-suite-web/src/test/groovy/org/grails/web/codecs/CodecSpec.groovy#L40
>>>
>>> [2]
>>> https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-core/src/test/groovy/org/grails/compiler/injection/DefaultDomainClassInjectorSpec.groovy#L17
>>>
>>> On Thu, Mar 9, 2017 at 2:29 PM, Paul King <[hidden email]> wrote:
>>>>
>>>> Dear community,
>>>>
>>>> I am happy to start the VOTE thread for a Groovy 2.4.10 release!
>>>>
>>>> This release includes 9 bug fixes/improvements as outlined in the
>>>> changelog:
>>>>
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12339743
>>>>
>>>> Tag:
>>>> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_4_10
>>>> Tag commit id: f2796bad0c5e5d1304e51331244b671ece60c351
>>>>
>>>> The artifacts to be voted on are located as follows (r18648).
>>>> Source release:
>>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/sources
>>>> Convenience binaries:
>>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/distribution
>>>>
>>>> Release artifacts are signed with a key from the following file:
>>>> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>>>>
>>>> Please vote on releasing this package as Apache Groovy 2.4.10.
>>>>
>>>> The vote is open for the next 72 hours and passes if a majority of at
>>>> least three +1 PMC votes are cast.
>>>>
>>>> [ ] +1 Release Apache Groovy 2.4.10
>>>> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
>>>> [ ] -1 Do not release Apache Groovy 2.4.10 because...
>>>>
>>>> Here is my vote:
>>>>
>>>> +1 (binding)
>>>
>>>



--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform






--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform




--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform




--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform




--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform





--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform

12