Bug tracker status

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug tracker status

Michael Baehr
As I'm in the "I should do something for Groovy" mood right now, I
looked at the bug tracker, trying to identify a bug that I could give
a shot (which is not easy neither being a Groovy guru nor having seen
the source code ever before).

I suggested a patch for one bug, but then stumbled over some other bug
reports that I couldn't reproduce. It would be helpful if somebody
(with the proper knowledge about what has been done in the last couple
of months) "cleans up" the bug list so that other people have a better
idea about what needs to be done.

A lot of the bug reports are very old (more than a year), but flagged
as "major" - this gives me a somewhat uneasy feeling ...

Michael

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Reply | Threaded
Open this post in threaded view
|

Re: Bug tracker status

Jochen Theodorou
Michael Baehr schrieb:

> As I'm in the "I should do something for Groovy" mood right now, I
> looked at the bug tracker, trying to identify a bug that I could give
> a shot (which is not easy neither being a Groovy guru nor having seen
> the source code ever before).
>
> I suggested a patch for one bug, but then stumbled over some other bug
> reports that I couldn't reproduce. It would be helpful if somebody
> (with the proper knowledge about what has been done in the last couple
> of months) "cleans up" the bug list so that other people have a better
> idea about what needs to be done.
>
> A lot of the bug reports are very old (more than a year), but flagged
> as "major" - this gives me a somewhat uneasy feeling ...

major is the default, that is why. checking old bugs if they are still
valid is a very good sart. Doing some work on DefaultGroovyMethods maybe
another.

So maybe one or more of

http://jira.codehaus.org/browse/GROOVY-1114
http://jira.codehaus.org/browse/GROOVY-1126
http://jira.codehaus.org/browse/GROOVY-1236
http://jira.codehaus.org/browse/GROOVY-1131
http://jira.codehaus.org/browse/GROOVY-1132

The are all concentrationg their implementation on DGM
(DefaultGroovyMethods) It is a big class, but looking at it should give
you a very good clue of what is happening there.

Of course you can always ask for help on the dev list

bye blackdrag


--
Jochen Theodorou
Groovy Tech Lead
http://blackdragsview.blogspot.com/

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Reply | Threaded
Open this post in threaded view
|

Re: Bug tracker status

Guillaume Laforge
Administrator
In reply to this post by Michael Baehr
On 9/9/06, Michael Baehr <[hidden email]> wrote:
> As I'm in the "I should do something for Groovy" mood right now, I
> looked at the bug tracker, trying to identify a bug that I could give
> a shot (which is not easy neither being a Groovy guru nor having seen
> the source code ever before).
> [...]

Your help and your contributions will be very much appreciated!
Thanks a lot :-)

--
Guillaume Laforge
Groovy Project Manager
http://glaforge.free.fr/blog/groovy

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Reply | Threaded
Open this post in threaded view
|

Re: Bug tracker status

Michael Baehr
In reply to this post by Jochen Theodorou
Let's see:

<a onclick="return top.js.OpenExtLink(window,event,this)" href="http://jira.codehaus.org/browse/GROOVY-1114" target="_blank">http://jira.codehaus.org/browse/GROOVY-1114
I guess it's meant to be "... like String.split(/\W/), not String.split(/\w/);

<a onclick="return top.js.OpenExtLink(window,event,this)" href="http://jira.codehaus.org/browse/GROOVY-1126" target="_blank">http://jira.codehaus.org/browse/GROOVY-1126
Understood

<a onclick="return top.js.OpenExtLink(window,event,this)" href="http://jira.codehaus.org/browse/GROOVY-1236" target="_blank">http://jira.codehaus.org/browse/GROOVY-1236
Understood

<a onclick="return top.js.OpenExtLink(window,event,this)" href="http://jira.codehaus.org/browse/GROOVY-1131" target="_blank"> http://jira.codehaus.org/browse/GROOVY-1131
public static Number next(Character self) { // Number/Character math ???
public static Number previous(Character self) {
++ and – should be closed under their type.
Guess that means that next and previous on Character should return Character. Correct?

<a onclick="return top.js.OpenExtLink(window,event,this)" href="http://jira.codehaus.org/browse/GROOVY-1132" target="_blank"> http://jira.codehaus.org/browse/GROOVY-1132
string.eachMatch(pattern_str) { match ->
found += match[0] + ' '
}
// but
(string=~ pattern_str).each { match ->
found += match + ' '
}
=> match vs match[] handling inconsistent
Which one (match or match[]) is the one that should be used in both cases?


Ok, I think I can fix all of those. You want one patch for all of them as its all in one class?

What else do I need to know (conventions, test cases etc.)?

Michael


On 9/9/06, Jochen Theodorou <[hidden email]> wrote:
> Michael Baehr schrieb:
> > As I'm in the "I should do something for Groovy" mood right now, I
> > looked at the bug tracker, trying to identify a bug that I could give
> > a shot (which is not easy neither being a Groovy guru nor having seen
> > the source code ever before).
> >
> > I suggested a patch for one bug, but then stumbled over some other bug
> > reports that I couldn't reproduce. It would be helpful if somebody
> > (with the proper knowledge about what has been done in the last couple

> > of months) "cleans up" the bug list so that other people have a better
> > idea about what needs to be done.
> >
> > A lot of the bug reports are very old (more than a year), but flagged
> > as "major" - this gives me a somewhat uneasy feeling ...
>
> major is the default, that is why. checking old bugs if they are still
> valid is a very good sart. Doing some work on DefaultGroovyMethods maybe
> another.
>
> So maybe one or more of
>
> http://jira.codehaus.org/browse/GROOVY-1114
> http://jira.codehaus.org/browse/GROOVY-1126
> http://jira.codehaus.org/browse/GROOVY-1236
> http://jira.codehaus.org/browse/GROOVY-1131
> http://jira.codehaus.org/browse/GROOVY-1132
>

> The are all concentrationg their implementation on DGM
> (DefaultGroovyMethods) It is a big class, but looking at it should give
> you a very good clue of what is happening there.
>
> Of course you can always ask for help on the dev list
>
> bye blackdrag
>
>
> --
> Jochen Theodorou
> Groovy Tech Lead
> http://blackdragsview.blogspot.com/
>
> ---------------------------------------------------------------------
> To unsubscribe from this list please visit:
>
>     http://xircles.codehaus.org/manage_email
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Bug tracker status

Michael Baehr
Moving to developer mailing list!

On 9/9/06, Michael Baehr <[hidden email]> wrote:
Let's see:


<a href="http://jira.codehaus.org/browse/GROOVY-1114" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://jira.codehaus.org/browse/GROOVY-1114
I guess it's meant to be "... like String.split(/\W/), not String.split(/\w/);


<a href="http://jira.codehaus.org/browse/GROOVY-1126" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://jira.codehaus.org/browse/GROOVY-1126
Understood


<a href="http://jira.codehaus.org/browse/GROOVY-1236" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://jira.codehaus.org/browse/GROOVY-1236
Understood


<a href="http://jira.codehaus.org/browse/GROOVY-1131" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)"> http://jira.codehaus.org/browse/GROOVY-1131
public static Number next(Character self) { // Number/Character math ???
public static Number previous(Character self) {
++ and – should be closed under their type.
Guess that means that next and previous on Character should return Character. Correct?


<a href="http://jira.codehaus.org/browse/GROOVY-1132" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)"> http://jira.codehaus.org/browse/GROOVY-1132
string.eachMatch(pattern_str) { match ->
found += match[0] + ' '
}
// but
(string=~ pattern_str).each { match ->
found += match + ' '
}
=> match vs match[] handling inconsistent
Which one (match or match[]) is the one that should be used in both cases?


Ok, I think I can fix all of those. You want one patch for all of them as its all in one class?

What else do I need to know (conventions, test cases etc.)?

Michael



On 9/9/06, Jochen Theodorou <[hidden email]> wrote:
> Michael Baehr schrieb:
> > As I'm in the "I should do something for Groovy" mood right now, I
> > looked at the bug tracker, trying to identify a bug that I could give
> > a shot (which is not easy neither being a Groovy guru nor having seen
> > the source code ever before).
> >
> > I suggested a patch for one bug, but then stumbled over some other bug
> > reports that I couldn't reproduce. It would be helpful if somebody
> > (with the proper knowledge about what has been done in the last couple

> > of months) "cleans up" the bug list so that other people have a better
> > idea about what needs to be done.
> >
> > A lot of the bug reports are very old (more than a year), but flagged
> > as "major" - this gives me a somewhat uneasy feeling ...
>
> major is the default, that is why. checking old bugs if they are still
> valid is a very good sart. Doing some work on DefaultGroovyMethods maybe
> another.
>
> So maybe one or more of
>
> <a href="http://jira.codehaus.org/browse/GROOVY-1114" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)"> http://jira.codehaus.org/browse/GROOVY-1114
> <a href="http://jira.codehaus.org/browse/GROOVY-1126" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://jira.codehaus.org/browse/GROOVY-1126
> <a href="http://jira.codehaus.org/browse/GROOVY-1236" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)"> http://jira.codehaus.org/browse/GROOVY-1236
> <a href="http://jira.codehaus.org/browse/GROOVY-1131" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://jira.codehaus.org/browse/GROOVY-1131
> <a href="http://jira.codehaus.org/browse/GROOVY-1132" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)"> http://jira.codehaus.org/browse/GROOVY-1132
>

> The are all concentrationg their implementation on DGM
> (DefaultGroovyMethods) It is a big class, but looking at it should give
> you a very good clue of what is happening there.
>
> Of course you can always ask for help on the dev list
>
> bye blackdrag
>
>
> --
> Jochen Theodorou
> Groovy Tech Lead
> <a href="http://blackdragsview.blogspot.com/" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)"> http://blackdragsview.blogspot.com/
>
> ---------------------------------------------------------------------
> To unsubscribe from this list please visit:
>
>     <a href="http://xircles.codehaus.org/manage_email" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://xircles.codehaus.org/manage_email
>
>

Reply | Threaded
Open this post in threaded view
|

Re: Bug tracker status

Guillaume Laforge
Administrator
In reply to this post by Michael Baehr
On 9/9/06, Michael Baehr <[hidden email]> wrote:
> [...]
> Ok, I think I can fix all of those. You want one patch for all of them as
> its all in one class?

Yup, one single patch will do, thanks.

> What else do I need to know (conventions, test cases etc.)?

Add a test case showing those bugs are fixed.
No particular convention that comes to mind this morning :-)

--
Guillaume Laforge
Groovy Project Manager
http://glaforge.free.fr/blog/groovy

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Reply | Threaded
Open this post in threaded view
|

Re: Bug tracker status

Michael Baehr
I had a full patch already, but Jochen prefers to get single patches, which means I'll have to send them one at a time.

Though this is more work, it makes sense as these are my first contributions and I might iteratively getting closer to what you really expect to see ...

So I will get the first one ready later today - definitely not before the Formula 1 race is over ;-)

Michael

On 9/10/06, Guillaume Laforge <[hidden email]> wrote:
On 9/9/06, Michael Baehr < [hidden email]> wrote:
> [...]
> Ok, I think I can fix all of those. You want one patch for all of them as
> its all in one class?

Yup, one single patch will do, thanks.

> What else do I need to know (conventions, test cases etc.)?

Add a test case showing those bugs are fixed.
No particular convention that comes to mind this morning :-)

--
Guillaume Laforge
Groovy Project Manager
http://glaforge.free.fr/blog/groovy

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email


Reply | Threaded
Open this post in threaded view
|

Re: Bug tracker status

Russel Winder
On Sun, 2006-09-10 at 14:02 +0200, Michael Baehr wrote:

> So I will get the first one ready later today - definitely not before
> the Formula 1 race is over ;-)

I think the television director must be tifosi, as the coverage follows
the Ferraris and misses all the action :-(  


--
Russel.
====================================================
Dr Russel Winder                +44 20 7585 2200
41 Buckmaster Road              +44 7770 465 077
London SW11 1EN, UK             [hidden email]

signature.asc (198 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Bug tracker status

Michael Baehr
You look at it the wrong way - by definition, the action is where the Ferraris are ;-)

Hey, the race is in Italy, what do you expect? ;-)

Michael

On 9/10/06, Russel Winder <[hidden email]> wrote:
On Sun, 2006-09-10 at 14:02 +0200, Michael Baehr wrote:

> So I will get the first one ready later today - definitely not before
> the Formula 1 race is over ;-)

I think the television director must be tifosi, as the coverage follows
the Ferraris and misses all the action :-(


--
Russel.
====================================================
Dr Russel Winder                +44 20 7585 2200
41 Buckmaster Road              +44 7770 465 077
London SW11 1EN, UK             [hidden email]